Repository navigation
refactor(site/src/pages/AgentsPage): split ChatTopBar into chatless frame and loaded bar - #29902
Closed
DanielleMaywood wants to merge 4 commits into
Closed
DanielleMaywood wants to merge 4 commits into
DanielleMaywood wants to merge 4 commits into
Conversation
DanielleMaywood
force-pushed
the
nullability/chat-input
branch
from
September 29, 2026 14:29
b008dba to
064e2a8
Compare
DanielleMaywood
force-pushed
the
nullability/chat-top-bar
branch
from
September 29, 2026 14:45
6aed723 to
64dc088
Compare
DanielleMaywood
force-pushed
the
nullability/chat-input
branch
from
October 6, 2026 08:07
d8a8364 to
e1401d6
Compare
… props AgentChatPage, AgentChatPageView, ChatPageContent, AgentCreateForm and AgentChatInput always pass the composer, page shell, attachment preview and skills menu props below, but the receiving components still declared them optional and defaulted or guarded them. Make them required and drop the dead defaults and guards: AgentChatPageView and its loading view props, ChatPageTimeline and ChatPageInput editor, MCP and loading props, AgentChatInput initialValue/onContentChange/plan mode/catalog loading, ChatMessageInput, SkillsTriggerMenu and AttachmentPreview callbacks and flags. ChatMessageInput always autofocuses, so its autoFocus prop is removed. Tests and stories now pass the values production sends; the story for plan mode without a toggle handler is removed.
…n the indicator (#29905)
DanielleMaywood
force-pushed
the
nullability/chat-input
branch
from
October 6, 2026 11:13
e1401d6 to
42a5dc8
Compare
…rame and loaded bar
DanielleMaywood
force-pushed
the
nullability/chat-top-bar
branch
from
October 6, 2026 11:18
64dc088 to
fff2b48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #29890.
ChatTopBarProps.chatwas optional only because the loading, error, and not-found views rendered the bar without a chat. The loaded page always passes aChat. This splits the component:ChatTopBarFramerenders the shared layout (back button, sidebar expand button, title area, PR slot, share slot, panel toggle). The loading and not-found views inAgentChatPageView.tsxandAgentChatPageErrorView.tsxuse it directly, with the same no-op panel toggle as before.ChatTopBarnow requireschat: Chatand fills the frame's slots, removing the repeatedchat?.,chat !== undefined, andchat ? ... : falsechecks.getParentChatIDnow requires aChat; theundefinedtest case is removed.NoTitlestory rendersChatTopBarFrame, keeping its story ID and screenshot.Rendered markup is unchanged for every view.
Part of the AgentsPage nullability cleanup; see #29888 for the methodology.
Verified:
pnpm lint:types,pnpm check,pnpm lint:oxlint,pnpm lint:compiler,pnpm lint:knip,pnpm test src/pages/AgentsPage, andpnpm test:storybookforChatTopBar,AgentsPageLayout, andAgentChatPageViewstories.Plan excerpt
Analysed on a local, unpushed merge of all cleanup branches; ranking script local only. After the bottom-up PRs only 43 dead slots remain, so what's left is nullability that is real at its origin. Two read-only agents reviewed the top origins in code. Guard counts from the tool overstate the win: many "guards" are real branches (loading, no workspace, first/last row).
ChatTopBarintoChatTopBarFrame(used by loading/error/not-found views) andChatTopBar({ chat: Chat })chatchecks,getParentChatID(undefined)This PR was generated by Coder Agents on behalf of @DanielleMaywood.