Skip to content

refactor(site/src/pages/AgentsPage): require org, MCP servers and URL transform in timeline - #29894

Merged
DanielleMaywood merged 1 commit into
nullability/chat-inputfrom
nullability/timeline-org-mcp-url
Oct 6, 2026
Merged

DanielleMaywood merged 1 commit into
nullability/chat-inputfrom
nullability/timeline-org-mcp-url

Conversation

@DanielleMaywood

Copy link
Copy Markdown
Collaborator

Stacked on #29890, which makes ChatPageTimelineProps.organizationId, urlTransform and mcpServers required. With that in place, every production path into the timeline passes these three values, so this PR narrows them on ConversationTimeline, ChatMessageItem, LifecycleHookNotice, BlockList, ReasoningDisclosure, ResponseBlock and Tool. ToolRendererProps keeps them optional because renderers are looked up dynamically.

Stories and tests now pass "organization-id", an empty MCP server list, and streamdown's defaultUrlTransform, which is what they rendered with when the props were omitted.

These are the 14 dead slots that #29891 left behind because they depended on #29890. This PR clears all 14. Part of the AgentsPage nullability cleanup; see #29888 for the methodology.


This PR was generated by Coder Agents on behalf of @DanielleMaywood.

@DanielleMaywood
DanielleMaywood marked this pull request as ready for review September 25, 2026 11:39
@DanielleMaywood
DanielleMaywood requested a review from a team as a code owner September 25, 2026 11:39
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T11:41:37.704193Z cfb8237 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@linear-code

linear-code Bot commented Sep 30, 2026

Copy link
Copy Markdown

CODAGT-1258

… transform in timeline

With `ChatPageTimelineProps.organizationId`, `urlTransform` and
`mcpServers` required, every production path into the timeline passes
these values. Narrow them on `ConversationTimeline`, `ChatMessageItem`,
`LifecycleHookNotice`, `BlockList`, `ReasoningDisclosure`,
`ResponseBlock` and `Tool`.

Stories and tests pass `organization-id`, an empty MCP server list and
streamdown's `defaultUrlTransform`, which is what they rendered with
when the props were omitted.
@DanielleMaywood
DanielleMaywood force-pushed the nullability/timeline-org-mcp-url branch from e3e1a2d to 67f59be Compare October 6, 2026 11:18
@DanielleMaywood
DanielleMaywood merged commit f2e995f into main Oct 6, 2026
27 checks passed
@DanielleMaywood
DanielleMaywood deleted the nullability/timeline-org-mcp-url branch October 6, 2026 12:30
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants