Skip to content

refactor(site/src/pages/AgentsPage): require always-passed right panel props - #29893

Merged
DanielleMaywood merged 1 commit into
mainfrom
nullability/right-panel
Oct 6, 2026
Merged

DanielleMaywood merged 1 commit into
mainfrom
nullability/right-panel

Conversation

@DanielleMaywood

Copy link
Copy Markdown
Collaborator

Each right panel component has a single production caller (AgentChatPageView, GitPanel, CommentableDiffViewer, DebugPanel, DebugRunCard, DebugStepCard), and those callers always pass these props. That made the optional types, defaults and guards dead. TerminalPanel is only rendered behind workspace && workspaceAgent, so its "agent not ready" fallback could never render. DebugStepCard.defaultOpen was always false, so the prop is removed. DebugRunCard no longer needs its own download = saveAs default, because DebugPanel owns that default and always forwards download.

This change makes the following props required: isExpanded/chatInputRef through GitPanel → RemoteDiffPanel/LocalDiffPanel → CommentableDiffViewer → DiffViewer, plus DiffViewer's line callbacks and annotationsVersion's input; GitPanel.isGitStatusLoading/everDirty; TerminalPanel.workspace/workspaceAgent/isHot/autoFocus/onReady; DesktopPanel.isVisible and DesktopPanelView.onPopOut; RightPanelAddTabControl.host/isRunning/onOpenWorkspaceApp/onOpenCommandApp/onOpenPort; DebugPanel.isVisible; DebugRunList/DebugRunCard.download; PillToggle.count; ToolEventCard.copyLabel; and debugExportFilename's exportedAt. The DiffViewer, GitPanel and TerminalPanel stories now pass the required args. The TerminalPanel AgentUnavailable story and the annotationsVersion(undefined) assertion are removed because production cannot reach them. These stay optional on purpose: DebugPanel.download (a test injection point that defaults to saveAs), DesktopToolbar.onPopOut (the pop-out page omits it), and LocalRepoContent.repo (it comes from Map.get).

Part of the AgentsPage nullability cleanup; see #29888 for the methodology. Dead slots in the right panel cluster: 39 before, 0 after.

This PR was generated by Coder Agents on behalf of @DanielleMaywood.

@DanielleMaywood
DanielleMaywood marked this pull request as ready for review September 25, 2026 11:14
@DanielleMaywood
DanielleMaywood requested a review from a team as a code owner September 25, 2026 11:14
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T11:18:17.797362Z 1ed8418 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

…l props

The right panel components (Git diff viewer, terminal, desktop, add-tab
control and debug panel) each have a single production caller that
always passes these props, so their optional types, defaults and
guards were dead.

Narrow the diff viewer callbacks, isExpanded and chatInputRef through
GitPanel, LocalDiffPanel, RemoteDiffPanel, CommentableDiffViewer and
DiffViewer; require TerminalPanel's workspace, agent, isHot, autoFocus
and onReady and drop its unreachable no-agent fallback; require
DesktopPanel.isVisible, DesktopPanelView.onPopOut, the add-tab
control's host, isRunning and open callbacks, and DebugPanel.isVisible.
In the debug panel, DebugRunList/DebugRunCard.download, PillToggle.count,
ToolEventCard.copyLabel and debugExportFilename's exportedAt become
required, and DebugStepCard loses its always-false defaultOpen prop.

Stories now pass the required values, the TerminalPanel
AgentUnavailable story and the annotationsVersion(undefined) assertion
are removed because production cannot reach them.
@linear-code

linear-code Bot commented Sep 30, 2026

Copy link
Copy Markdown

CODAGT-1258

@DanielleMaywood
DanielleMaywood merged commit 21212e4 into main Oct 6, 2026
27 checks passed
@DanielleMaywood
DanielleMaywood deleted the nullability/right-panel branch October 6, 2026 07:35
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants