Repository navigation
refactor(site/src/pages/AgentsPage): require always-passed right panel props - #29893
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…l props The right panel components (Git diff viewer, terminal, desktop, add-tab control and debug panel) each have a single production caller that always passes these props, so their optional types, defaults and guards were dead. Narrow the diff viewer callbacks, isExpanded and chatInputRef through GitPanel, LocalDiffPanel, RemoteDiffPanel, CommentableDiffViewer and DiffViewer; require TerminalPanel's workspace, agent, isHot, autoFocus and onReady and drop its unreachable no-agent fallback; require DesktopPanel.isVisible, DesktopPanelView.onPopOut, the add-tab control's host, isRunning and open callbacks, and DebugPanel.isVisible. In the debug panel, DebugRunList/DebugRunCard.download, PillToggle.count, ToolEventCard.copyLabel and debugExportFilename's exportedAt become required, and DebugStepCard loses its always-false defaultOpen prop. Stories now pass the required values, the TerminalPanel AgentUnavailable story and the annotationsVersion(undefined) assertion are removed because production cannot reach them.
DanielleMaywood
force-pushed
the
nullability/right-panel
branch
from
September 29, 2026 14:29
1ed8418 to
52f103b
Compare
jakehwll
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each right panel component has a single production caller (
AgentChatPageView,GitPanel,CommentableDiffViewer,DebugPanel,DebugRunCard,DebugStepCard), and those callers always pass these props. That made the optional types, defaults and guards dead.TerminalPanelis only rendered behindworkspace && workspaceAgent, so its "agent not ready" fallback could never render.DebugStepCard.defaultOpenwas alwaysfalse, so the prop is removed.DebugRunCardno longer needs its owndownload = saveAsdefault, becauseDebugPanelowns that default and always forwardsdownload.This change makes the following props required:
isExpanded/chatInputRefthroughGitPanel→RemoteDiffPanel/LocalDiffPanel→CommentableDiffViewer→DiffViewer, plusDiffViewer's line callbacks andannotationsVersion's input;GitPanel.isGitStatusLoading/everDirty;TerminalPanel.workspace/workspaceAgent/isHot/autoFocus/onReady;DesktopPanel.isVisibleandDesktopPanelView.onPopOut;RightPanelAddTabControl.host/isRunning/onOpenWorkspaceApp/onOpenCommandApp/onOpenPort;DebugPanel.isVisible;DebugRunList/DebugRunCard.download;PillToggle.count;ToolEventCard.copyLabel; anddebugExportFilename'sexportedAt. TheDiffViewer,GitPanelandTerminalPanelstories now pass the required args. TheTerminalPanelAgentUnavailablestory and theannotationsVersion(undefined)assertion are removed because production cannot reach them. These stay optional on purpose:DebugPanel.download(a test injection point that defaults tosaveAs),DesktopToolbar.onPopOut(the pop-out page omits it), andLocalRepoContent.repo(it comes fromMap.get).Part of the AgentsPage nullability cleanup; see #29888 for the methodology. Dead slots in the right panel cluster: 39 before, 0 after.
This PR was generated by Coder Agents on behalf of @DanielleMaywood.