Repository navigation
refactor(site/src/pages/AgentsPage): require always-passed timeline and tool props - #29891
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 25, 2026
Merged
Closed
DanielleMaywood
force-pushed
the
nullability/conversation-tools
branch
2 times, most recently
from
September 29, 2026 14:29
8fd105a to
68e6991
Compare
jakehwll
approved these changes
Oct 6, 2026
DanielleMaywood
force-pushed
the
nullability/conversation-tools
branch
2 times, most recently
from
October 6, 2026 11:12
b074f1b to
15526c0
Compare
DanielleMaywood
added a commit
that referenced
this pull request
Oct 6, 2026
… transform in timeline (#29894) Stacked on #29890, which makes `ChatPageTimelineProps.organizationId`, `urlTransform` and `mcpServers` required. With that in place, every production path into the timeline passes these three values, so this PR narrows them on `ConversationTimeline`, `ChatMessageItem`, `LifecycleHookNotice`, `BlockList`, `ReasoningDisclosure`, `ResponseBlock` and `Tool`. `ToolRendererProps` keeps them optional because renderers are looked up dynamically. Stories and tests now pass `"organization-id"`, an empty MCP server list, and streamdown's `defaultUrlTransform`, which is what they rendered with when the props were omitted. These are the 14 dead slots that #29891 left behind because they depended on #29890. This PR clears all 14. Part of the AgentsPage nullability cleanup; see #29888 for the methodology. --- _This PR was generated by Coder Agents on behalf of @DanielleMaywood._
…nd tool props ChatPageTimeline always passes stream tools, live status, subagent maps and the stream flags to ConversationTimeline, and every hop below it (ChatMessageItem, AssistantOutput, BlockList, Tool, the tool renderers and AttachmentBlock) forwards those values unconditionally. The optional types, defaults and guards along that path were dead. Narrow them to required, drop the defaults and `?.`/`??`/`Boolean()` guards, and remove the `showTextStatus`/`showStatus` attachment props that every caller set to true. `resolveAgentDisplayState` no longer accepts an undefined mode, and `useDeadlineCountdown` no longer accepts an undefined deadline. Stories and tests now pass the values production sends.
DanielleMaywood
force-pushed
the
nullability/conversation-tools
branch
from
October 6, 2026 13:28
15526c0 to
8035d49
Compare
DanielleMaywood
enabled auto-merge (squash)
October 6, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChatPageTimelineis the only production caller ofConversationTimeline. It always passesstreamTools,liveStatus,subagentStatusOverrides,subagentVariants,isChatCompleted,hasActiveStream,isAwaitingFirstStreamChunkandshowDesktopPreviews. Every hop below it (ChatMessageItem,AssistantOutput,BlockList,Tool, the tool renderers,UserMessageContentandAttachmentBlock) forwards the subagent maps, display modes, streaming flags and preview callbacks unconditionally. The optional types, defaults,?./??guards andBoolean()wrappers along that path were dead.This PR makes those props required and deletes the dead handling.
AttachmentBlock.showTextStatusandRemoteTextAttachmentButton.showStatusare removed because every caller passedtrue.AttachmentPreviewFrame.hrefdropsnull.resolveAgentDisplayStateno longer accepts anundefinedmode, anduseDeadlineCountdownno longer accepts anundefineddeadline. An invalid deadline still returns 0 through the existingNumber.isFinitecheck.ExecuteTool.errorTextkeeps its||fallback because production can send"".ToolCall.Root.expandedstays optional becauseundefinedthere means uncontrolled.Stories and tests now pass the values production sends.
ConversationTimelinestories use an idlebuildLiveStatus()and empty maps. TheToolstory metas setisError: false, empty subagent maps and"auto"display modes, so the screenshots do not change.ExecuteToolerror stories seterrorTextto match their error block. Theundefinedcase is removed fromdisplayMode.test.ts. TheReasoningDisclosurehunk inMessageBlocks.tsxis mostly whitespace, because Biome collapsed the destructuring once the defaults were gone.organizationId,urlTransformandmcpServersare not part of this PR. #29894, now onmain, made them required through the timeline and tools.This PR also carries #29909, which was merged into this branch as its own commit. It deletes four
ToolCallprops that no caller passes (Root.view,Root.onViewChange,Label.shimmerWhenActive,Header.headerClassName) and drops a redundant ternary inProcessOutputTool. It also has one behavior change: inGenericToolRenderer, a model intent that is whitespace only used to render a blank label and now falls back to the default tool label. A test inTool.test.tsxcovers this.Part of the AgentsPage nullability cleanup; see #29888 for the methodology. Dead slots for this cluster: 69 before, 14 after this PR. The 14 are the
organizationId/urlTransform/mcpServerschain, which #29894 resolved onmain.Per-finding decisions
useDeadlineCountdown.deadline!deadlineguard removedToolCallRootProps.hasContent= truedefault droppedReadFilesTool.expanded/onExpandedChangeReadFilesTool;ToolCall.Root.expandedstays optionalCreateWorkspaceTool.createdcreated === falsebecomes!createdExecuteToolProps.errorText/isBackgrounded||fallback kept (empty string is possible)ProcessOutputToolProps.processRunninggetSubagentLabel.showDesktopPreview,SubagentStatusIcon.iconKind/showDesktopPreview,SubagentTool.isTimeout/showDesktopPreviewWorkspaceLifecycleToolProps.noBuildToolProps.isError/subagentTitles/subagentVariants/shellToolDisplayMode/codeDiffDisplayModeToolRendererPropsmaps and display modes,ExecuteTool/ProcessOutputTool.shellToolDisplayMode,WriteFileTool/EditFilesTool.codeDiffDisplayMode,resolveAgentDisplayState.mode?? "auto"in keys andcase undefinedremovedPreviewTextAttachment.fileName,InlineTextAttachmentButton.*,RemoteTextAttachmentButton.fileName/mediaType/onPreview,RemoteImageBlock.onImageClick,AttachmentBlock.onImageClick/onTextFileClick,AttachmentPreviewFrame.hrefAttachmentBlock.showTextStatus,RemoteTextAttachmentButton.showStatustrueReasoningDisclosure.isStreaming/thinkingDisplayMode,BlockListProps.isStreaming/subagentTitles/subagentVariants/onImageClick/onTextFileClick/hasUserResponseAfterAskQuestion,LiveActivitySlot.interruptingderiveMessageDisplayState.isAwaitingFirstStreamChunkUserMessageContent.isEditing/onImageClick/onTextFileClickChatMessageItem.subagentTitles/subagentVariantsConversationTimelineProps.streamTools/liveStatus/subagentStatusOverrides/subagentVariants/isChatCompleted/showDesktopPreviews/hasActiveStream/isAwaitingFirstStreamChunkliveStatusguards andBoolean()wrappers removedorganizationId,urlTransform,mcpServerschain (14 slots)mainby #29894This PR was generated by Coder Agents on behalf of @DanielleMaywood.