Skip to content

refactor(site): remove workspace search results from the filter combobox - #29874

Merged
tracyjohnsonux merged 5 commits into
mainfrom
refactor/filter-combobox-remove-workspace-previews
Sep 28, 2026
Merged

tracyjohnsonux merged 5 commits into
mainfrom
refactor/filter-combobox-remove-workspace-previews

Conversation

@tracyjohnsonux

@tracyjohnsonux tracyjohnsonux commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Removes the "Jump to workspace" previews from the Workspaces filter. Typing free text no longer lists up to five matching workspaces in the dropdown that you can click to open.

Typed text still searches workspaces by name: it is committed to the filter query and narrows the workspace table as before. The dropdown now only offers filters (categories and matching values), so it stays about filtering rather than mixing in navigation. It still opens on focus and while typing. For a name that matches no filter, the dropdown now shows "No filters found." in place of workspace rows, and the table is still filtered by the name.

Removes the generic search-result support from FilterCombobox as well, since Workspaces was its only caller: the getSearchResults, onSearchResultSelect, and searchResultsLabel props, the SearchResult type, the search-results query with its loading and error handling, and the related stories. Category row previews (categoryPreviews) are unchanged here.

Split out of #29426 so this product change can be reviewed on its own.

Why remove rather than keep: the workspace rows added noise to a dropdown that should be about filters, and the component has only been dogfooded internally and has not shipped in a release, so no users lose a feature they rely on.


Generated with Coder Agents on behalf of @tracyjohnsonux.

@tracyjohnsonux
tracyjohnsonux marked this pull request as ready for review September 25, 2026 08:48
@tracyjohnsonux

Copy link
Copy Markdown
Collaborator Author

/coder-agents-review

@coder-agents-review

coder-agents-review Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Chat: Review posted | View chat
Requested: 2026-09-25 11:19 UTC by @tracyjohnsonux

Review history
  • R1 (2026-09-25): 10 reviewers, 1 Nit, 2 P3, 5 P4, COMMENT. Review
  • R2 (2026-09-25): 6 reviewers, 1 Nit, 2 P3, 8 P4, COMMENT. Review
  • R3 (2026-09-25): 6 reviewers, 1 Nit, 2 P3, 8 P4, APPROVE. Review

deep-review v0.13.0 | Round 3 | 5393f9d..08ac54f

Last posted: Round 3, 11 findings (2 P3, 8 P4, 1 Nit), APPROVE. Review

Finding inventory

Finding inventory: PR #29874

Findings

# Sev Status Location Summary Round Reviewer Posted
CRF-1 P3 Author fixed (d6d24fb) useFilterCombobox.ts:601 Tab comment still describes removed resource preview rows R1 Netero Yes
CRF-2 P3 Author contested; panel closed R2 (1/1 accept) FilterCombobox.tsx:332 Plain name search now shows "No filters found." and no story covers free-text typing R1 Netero Yes
CRF-3 P4 Author fixed (d6d24fb) useFilterCombobox.ts:382 typeaheadError and typeaheadErrorLabel are leftover aliases of suggestionsError R1 Netero Yes
CRF-4 P4 Author fixed (d6d24fb) useFilterCombobox.ts:54 close action input "restore" or "clear" yields the same state at every call site R1 Zoro Yes
CRF-5 P4 Author fixed (d6d24fb) useFilterCombobox.ts:388 hasTypeaheadQuery repeats valueSuggestionsLoading conditions; one-reader intermediate R1 Zoro Yes
CRF-6 P4 Author fixed (PR description edit, IC_kwDOGkVX1s8AAAABW4XBhw) useFilterCombobox.ts:183 PR description claims dropdown no longer opens for workspace rows; open never depended on them R1 Pariston Yes
CRF-7 P4 Author fixed (PR description edit, IC_kwDOGkVX1s8AAAABW4XBhw) useFilterCombobox.ts:326 PR description calls removed feature "preview" while category row previews remain R1 Leorio Yes
CRF-8 Nit Author fixed (d6d24fb) primitives.tsx:194 FilterComboboxItem doc lists caller row behaviors that went stale in this PR R1 Gon P2 Yes
CRF-9 P2 Dropped by orchestrator (second clause states the no-empty-gap purpose the expression does not) useFilterCombobox.ts:386 Spinner comment restates the expression R1 Gon No
CRF-10 OOS Out of scope (body) FilterCombobox.tsx:29 Doc comment on unchanged line calls generic component "workspace filter input" R1 Gon No
CRF-11 OOS Out of scope (body) useFilterCombobox.ts:157 Hook doc on unchanged line says "workspace" and lists internals R1 Gon No
CRF-12 OOS Out of scope (body) useFilterCombobox.ts:643 Unchanged typeahead object comment repeats key name and fields R1 Gon No
CRF-13 Note Dropped by orchestrator (process remark; actionable parts are CRF-1 and CRF-8) useFilterCombobox.ts:156 Author did not recheck rewritten comments R1 Gon No
CRF-14 Nit Dropped by orchestrator (no release contains the feature, so refactor matches release-to-release behavior) PR title refactor type for a user-visible removal R1 Leorio No
CRF-15 Note Dropped by orchestrator (confirmation; asks for nothing) PR description Description claims verified R1 Leorio No
CRF-16 Note Dropped by orchestrator (confirmation; asks for nothing) useFilterCombobox.ts:388 Typeahead states still cover every state R1 Nami No
CRF-17 Note Dropped by orchestrator (confirmation; asks for nothing) WorkspacesFilter.tsx:119 Removal justified, feature unreleased R1 Luffy No
CRF-18 Note Dropped by orchestrator (confirmation; asks for nothing) types.ts:33 Generic API removal justified R1 Zoro No
CRF-19 OOS Out of scope (body) useFilterCombobox.ts:374 typeaheadError repeats the typeaheadActive condition (present at base as suggestionsError) R2 Netero No
CRF-20 P4 Author fixed (08ac54f) useFilterCombobox.ts:435 Value-suggestion input clearing depends on setCommittedFreeText ordering; no story asserts empty input R2 Nami Yes
CRF-21 Note Dropped by orchestrator (confirmation; asks for nothing) useFilterCombobox.ts:381 Round 2 commit changes no typeahead state R2 Nami No
CRF-22 P4 Author fixed (08ac54f) useFilterCombobox.ts:372 Error-as-done-loading comment separated from the !typeaheadError term it explains; "forever" overstated R2 Leorio P4, Gon P2 Yes
CRF-23 P2 Dropped by orchestrator (round 1 review asked for this exact sentence; no new facts) useFilterCombobox.ts:590 Tab comment repeats the code below R2 Gon No
CRF-24 OOS Out of scope (body) useFilterCombobox.ts:119 deriveStatusMessage comment says "terminal state" but returns loading text R2 Gon No
CRF-25 Note Dropped by orchestrator (process remark; actionable part is CRF-22) useFilterCombobox.ts:116 Comment quality pattern in fix commit R2 Gon No
CRF-26 OOS Out of scope (body) FilterCombobox.tsx:332 "No filters found" written three times with inconsistent period R2 Gon No
CRF-27 OOS Out of scope (body) FilterCombobox.tsx:413 Curly vs straight apostrophe across popup error messages R2 Gon No
CRF-28 P4 Author fixed (PR retitled, IC_kwDOGkVX1s8AAAABW5XHbw) useFilterCombobox.ts:326 PR title still says "workspace previews" while category previews remain R2 Leorio Yes
CRF-29 Note Dropped by orchestrator (confirmation; asks for nothing) useFilterCombobox.ts:116 SUGGESTIONS_ERROR_MESSAGE doc is accurate R2 Leorio No
CRF-30 P2 Dropped by orchestrator (round 2 review supplied this wording; the hook exposes retryTypeahead, so Retry is its own contract) useFilterCombobox.ts:379 CRF-22 comment names the view's Retry button R3 Gon No
CRF-31 OOS Out of scope (body) useFilterCombobox.ts:382 No story covers one category failing while another fetches (gap present at base) R3 Chopper No
CRF-32 Note Dropped by orchestrator (confirmation; asks for nothing) useFilterCombobox.ts:378 CRF-22 fix accurate; fix commit subject not kept after squash R3 Leorio No

Contested and acknowledged

CRF-2 (P3, FilterCombobox.tsx:332) - name search shows "No filters found." with no story

  • Finding: After removing the workspace rows, typing a workspace name that matches no filter shows and announces "No filters found." while the table filters by that name, and no story types plain free text and asserts the emitted query or dropdown content. Proposed: decide the dropdown content for a name search and add a story asserting the emitted query and that content.
  • Author defense: Intended: the dropdown lists only filters, so "No filters found." is accurate, and the table still filters by name. The stacked PR feat(site/src): redesign the workspace filter menu with flyouts and inline options #29426 hides the dropdown when no filter matches and holds back possible filter text; its Vitest test "emits unmatched typed text without selecting a filter" covers the emitted query. The PR description now states the behavior.
  • Panel closure (R2, 1/1): Netero, the agent that raised it (same agent, resumed), accepted. It stated the consequence (until feat(site/src): redesign the workspace filter menu with flyouts and inline options #29426 merges, a name search that matches no filter shows and announces "No filters found" while the table filters) and judged it acceptable because the text is accurate for a filters-only dropdown, the description documents it, and handleInputValueChange (the free-text emission path) is unchanged by this PR. It verified FilterCombobox.test.tsx:160 on origin/pull/29426/head.

Round log

Round 1

Netero first pass: 2 P3, 1 P4, no P0. Proceeded to panel.

Full panel (round 1). Specialists: ging-ts, ging-react (.ts/.tsx changed), nami (UI state), luffy (PR removes a user-facing feature and describes itself as a product change). Core: pariston, mafuuu. Pool: bisky (tests changed, required), gon and leorio (once-per-PR floor). Wildcard: zoro (random draw from distilled set). 9 panel reviewers plus wildcard exceeds the focused target of 6-8 because luffy was added as a triggered specialist.

Cross-check: ging-ts, ging-react, mafuuu, bisky reported no findings. Gon's comment findings rated P2 were reclassified: CRF-8 downgraded to Nit (keep argument: the list in a shared primitive's doc goes stale whenever a row type changes, as this PR shows; downgrade reason: the edited text is accurate today and the cost is doc wording); CRF-9 dropped (keep argument: the first clause restates the boolean; drop reason: the second clause states a purpose the code does not); CRF-10 to CRF-12 moved out of scope because the flagged text sits on lines the PR does not change and the PR does not change its truth. Pariston's Note became CRF-6 at P4 because it asks the author to correct the description. Leorio's title Nit dropped (keep argument: refactor implies no behavior change and main-branch users lose the rows; drop reason: the preview commit d4b86cb is absent from release/2.37 and v2.37.3, verified, so no release-to-release behavior changes and feat would list the removal of unreleased UI under Features). Confirmation Notes dropped.

Result: 2 P3, 5 P4, 1 Nit posted; 3 out of scope. Reviewed against 5393f9d..b9708f6.

Round 2

Churn guard PROCEED: CRF-1, 3, 4, 5, 8 fixed in d6d24fb; CRF-6, 7 fixed in the PR description; CRF-2 contested. Inventory validation: dropped and out-of-scope rows from round 1 still hold against d6d24fb (spinner comment, doc comments, and title type unchanged).

Netero resumed (same agent) for the CRF-2 dispute check-in and accepted the defense (1/1). Netero raised CRF-19; moved out of scope because the same expression exists at the base under suggestionsError and the PR only renamed the line.

Fix round (not a restructure: no files added or moved, the only changes fix prior findings). Panel: ging-ts, ging-react, nami (triggers on changed .ts/.tsx files), gon and leorio (fix commit touched comments, a doc comment, and an error string), wildcard knov (random draw). All new agents.

Cross-check: ging-ts, ging-react, knov reported no findings. CRF-22 converged (Leorio P4, Gon P2); settled at P4 (keep argument: the comment's reason is inaccurate and now annotates a declaration with no loading logic; downgrade reason: behavior is correct and the cost is reader time, matching Leorio's traced P4). CRF-23 dropped (keep argument: the Tab comment restates lines 603-611; drop reason: round 1 asked for that sentence and nothing changed since). CRF-24, 26, 27 target text unchanged since the base. CRF-28 kept at P4 (keep argument: squash merge makes the title the permanent commit subject; drop argument considered: "workspace" qualifies it).

Result: 3 P4 posted; 4 out of scope. Reviewed against 5393f9d..d6d24fb.

Round 3

Churn guard PROCEED: CRF-20 and CRF-22 fixed in 08ac54f, CRF-28 fixed by retitle. Inventory validation: dropped and out-of-scope rows still hold (CRF-9's comment gained a sentence, which strengthens its drop reason; title type still refactor). Author comment IC_kwDOGkVX1s8AAAABW5XHbw says the round 2 out-of-scope items predate the PR and stay unchanged; that is an author-agent statement, not a human ticket or acceptance.

Netero (new agent, no contested findings): no findings; verified both fixes and ran stories (23/23).

Fix round (delta: one story assertion, one comment). Panel: ging-ts, ging-react, nami (triggers on changed .ts/.tsx), gon (comment changed), leorio (new commit message), wildcard chopper (random draw). All new agents.

Cross-check: ging-ts, ging-react, nami, chopper reported no in-scope findings. CRF-30 dropped (keep argument: a hook comment naming a view control goes stale if the view changes; drop reason: the round 2 review prescribed this sentence and retryTypeahead is the hook's action). CRF-31 out of scope (the base had the same gap under valueSuggestionsLoading).

Result: no in-scope findings; all prior findings resolved. APPROVE (tool downgrades to COMMENT). Reviewed against 5393f9d..08ac54f.

About deep-review

CRF = Coder Review Finding (P0-P4, Nit, Note)

Reviewer Focus
Bisky tests
Chopper ops/errors
Churn-guard change verification
Ging language modernization
Gon naming
Hisoka edge cases
Killua perf
Kite change integrity
Knov contracts
Knuckle SQL
Komugi flake/determinism
Kurapika security
Law decomposition
Leorio docs
Luffy product
Mafu-san process
Mafuuu contracts
Melody dispatch/pairing
Meruem structural
Nami frontend
Netero mechanical checks
Pariston premise testing
Pen-botter product gaps
Razor verification
Robin duplication
Ryosuke Go arch
Takumi concurrency
Zoro shape

🤖 Managed by Coder Agents.

@coder-agents-review coder-agents-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes the "Jump to workspace" rows from the Workspaces filter dropdown and the search-result support from FilterCombobox. Findings: 2 P3, 5 P4, 1 Nit.

Out of scope (needs a ticket or explicit acceptance by a human):

  • site/src/components/Filter/FilterCombobox/FilterCombobox.tsx:29: the doc comment calls the generic component a "workspace filter input" and sits on the unexported FilterComboboxProps type, so readers may treat the component as workspace-specific and hovering FilterCombobox shows no doc.
  • site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:157: the hook doc calls it the "unified workspace filter combobox" and lists internals instead of the caller contract, so readers may treat the hook as workspace-specific.
  • site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:643: the comment on the typeahead object repeats the key name and the fields listed below it, adding words without information.

site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:601

P3 [CRF-1] The Tab-completion comment still describes "a highlighted resource preview", a row type this PR removes. (Netero)

After this PR the browsing list contains only category rows and value-suggestion rows, and Tab handles both at lines 614-626, so the comment explains a case that can no longer occur. Replace it with one line: Tab completes the highlighted category or value suggestion and otherwise moves focus.

🤖

site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:183

P4 [CRF-6] The PR description says the dropdown "does not open just to show workspace rows", but opening never depended on those rows. (Pariston)

open is mode !== "closed", and handleInputFocus and typeFreeText set mode to "browsing" before and after this PR, so the dropdown opens on focus and on every keystroke either way. What changes is its content: a name that matches no filter now shows "No filters found." instead of workspace rows. Correct that sentence so readers do not expect a change in when the dropdown opens.

🤖

site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:326-359

P4 [CRF-7] The PR description calls the removed feature "preview support", but FilterCombobox keeps a different feature with that name: category row previews (categoryPreviews, CategoryPreviewText, previewOptions in these lines). (Leorio)

A reader who sees "removes the generic preview support ... the preview query and loading and error handling" and then finds previewOptions still queried here cannot tell from the description whether the removal is complete. The removed code called itself search results (SearchResult, getSearchResults, searchResultsQuery). Use that name in the description and state that category row previews are unchanged.

🤖

🤖 This review was automatically generated with Coder Agents.

@tracyjohnsonux

Copy link
Copy Markdown
Collaborator Author

Review-body findings:

  • CRF-1: fixed in d6d24fb. The Tab comment now says that Tab completes the highlighted category or value suggestion and otherwise moves focus.
  • CRF-6 and CRF-7: fixed in the PR description. It now says the dropdown still opens on focus and while typing, calls the removed feature search results, and notes that category row previews are unchanged.

Generated by Coder Agents

@tracyjohnsonux

Copy link
Copy Markdown
Collaborator Author

/coder-agents-review

@coder-agents-review coder-agents-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This round reviews d6d24fb. Findings: 3 P4.

Fixed and verified: the stale Tab comment, the error-label alias, the close parameter, the repeated loading conditions, the FilterComboboxItem doc, and both PR description corrections. The "No filters found." finding for name searches is closed: the description now documents the behavior, and the stacked PR #29426 test "emits unmatched typed text without selecting a filter" exists at FilterCombobox.test.tsx:160.

Out of scope (needs a ticket or explicit acceptance by a human):

  • site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:374: typeaheadError repeats activeCategoryKey === null && isBrowsing, which typeaheadActive defines on the next line (the base had the same repetition under suggestionsError), so the two definitions of an active typeahead can drift.
  • site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:119: the deriveStatusMessage comment says "each terminal state", but the function also returns loading text, so the comment misdescribes its output.
  • site/src/components/Filter/FilterCombobox/FilterCombobox.tsx:332: "No filters found" is written three times, twice with a period (FilterCombobox.tsx:332, :439) and once without (useFilterCombobox.ts:146), so the visible and announced text can drift apart.
  • site/src/components/Filter/FilterCombobox/FilterCombobox.tsx:413: the category error uses a curly apostrophe (Couldn’t) while SUGGESTIONS_ERROR_MESSAGE and the live-region text use a straight one, so the two popup errors render different apostrophes.

site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:326-359

P4 [CRF-28] The PR title still calls the removed feature "workspace previews", while FilterCombobox keeps a feature named previews (categoryPreviews, CategoryPreviewText, previewOptions in these lines). (Leorio)

The description now says search results, but the repository squash-merges, so the title becomes the only commit subject on main and a reader of git log meets the ambiguity the description fix removed. Retitle to refactor(site): remove workspace search results from the filter combobox, which matches the removed identifiers (SearchResult, getSearchResults).

🤖

🤖 This review was automatically generated with Coder Agents.

…eview of the workspace search result removal
@tracyjohnsonux tracyjohnsonux changed the title refactor(site): remove workspace previews from the filter combobox refactor(site): remove workspace search results from the filter combobox Sep 25, 2026
@tracyjohnsonux

Copy link
Copy Markdown
Collaborator Author

CRF-28: retitled to refactor(site): remove workspace search results from the filter combobox.

The four out-of-scope notes from review 5316715693 (the repeated active-typeahead condition, the deriveStatusMessage comment, the three "No filters found" strings, and the curly apostrophe) all predate this PR. #29426 replaces that dropdown state, so this PR leaves them unchanged.

Generated by Coder Agents

@tracyjohnsonux

Copy link
Copy Markdown
Collaborator Author

/coder-agents-review

@coder-agents-review coder-agents-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This round reviews 08ac54f. No new findings.

Fixed and verified: CrossCategoryValueSuggestions now asserts the input is empty after picking a value suggestion, the comment above typeaheadLoading now explains the !typeaheadError term and matches the code, and the title now says search results. All findings from earlier rounds are resolved.

The out-of-scope items from earlier rounds and the one below still need a human to file a ticket or accept them.

Out of scope (needs a ticket or explicit acceptance by a human):

  • site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:382: no story covers one category query failing while another is still fetching (TypeaheadErrorRetry has one category), so removing !typeaheadError would likely still pass every story while showing a spinner instead of the error and Retry. The base had the same gap under valueSuggestionsLoading.

🤖 This review was automatically generated with Coder Agents.

…box-remove-workspace-previews

# Conflicts:
#	site/src/components/Filter/FilterCombobox/FilterCombobox.tsx
#	site/src/components/Filter/FilterCombobox/types.ts
#	site/src/pages/WorkspacesPage/filter/WorkspacesFilter.tsx
@tracyjohnsonux
tracyjohnsonux merged commit 778f4e9 into main Sep 28, 2026
26 of 27 checks passed
@tracyjohnsonux
tracyjohnsonux deleted the refactor/filter-combobox-remove-workspace-previews branch September 28, 2026 21:28
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants