Repository navigation
refactor(site): remove workspace search results from the filter combobox - #29874
Conversation
|
/coder-agents-review |
|
Chat: Review posted | View chat Review historydeep-review v0.13.0 | Round 3 | Last posted: Round 3, 11 findings (2 P3, 8 P4, 1 Nit), APPROVE. Review Finding inventoryFinding inventory: PR #29874Findings
Contested and acknowledgedCRF-2 (P3, FilterCombobox.tsx:332) - name search shows "No filters found." with no story
Round logRound 1Netero first pass: 2 P3, 1 P4, no P0. Proceeded to panel. Full panel (round 1). Specialists: ging-ts, ging-react (.ts/.tsx changed), nami (UI state), luffy (PR removes a user-facing feature and describes itself as a product change). Core: pariston, mafuuu. Pool: bisky (tests changed, required), gon and leorio (once-per-PR floor). Wildcard: zoro (random draw from distilled set). 9 panel reviewers plus wildcard exceeds the focused target of 6-8 because luffy was added as a triggered specialist. Cross-check: ging-ts, ging-react, mafuuu, bisky reported no findings. Gon's comment findings rated P2 were reclassified: CRF-8 downgraded to Nit (keep argument: the list in a shared primitive's doc goes stale whenever a row type changes, as this PR shows; downgrade reason: the edited text is accurate today and the cost is doc wording); CRF-9 dropped (keep argument: the first clause restates the boolean; drop reason: the second clause states a purpose the code does not); CRF-10 to CRF-12 moved out of scope because the flagged text sits on lines the PR does not change and the PR does not change its truth. Pariston's Note became CRF-6 at P4 because it asks the author to correct the description. Leorio's title Nit dropped (keep argument: refactor implies no behavior change and main-branch users lose the rows; drop reason: the preview commit d4b86cb is absent from release/2.37 and v2.37.3, verified, so no release-to-release behavior changes and feat would list the removal of unreleased UI under Features). Confirmation Notes dropped. Result: 2 P3, 5 P4, 1 Nit posted; 3 out of scope. Reviewed against 5393f9d..b9708f6. Round 2Churn guard PROCEED: CRF-1, 3, 4, 5, 8 fixed in d6d24fb; CRF-6, 7 fixed in the PR description; CRF-2 contested. Inventory validation: dropped and out-of-scope rows from round 1 still hold against d6d24fb (spinner comment, doc comments, and title type unchanged). Netero resumed (same agent) for the CRF-2 dispute check-in and accepted the defense (1/1). Netero raised CRF-19; moved out of scope because the same expression exists at the base under Fix round (not a restructure: no files added or moved, the only changes fix prior findings). Panel: ging-ts, ging-react, nami (triggers on changed .ts/.tsx files), gon and leorio (fix commit touched comments, a doc comment, and an error string), wildcard knov (random draw). All new agents. Cross-check: ging-ts, ging-react, knov reported no findings. CRF-22 converged (Leorio P4, Gon P2); settled at P4 (keep argument: the comment's reason is inaccurate and now annotates a declaration with no loading logic; downgrade reason: behavior is correct and the cost is reader time, matching Leorio's traced P4). CRF-23 dropped (keep argument: the Tab comment restates lines 603-611; drop reason: round 1 asked for that sentence and nothing changed since). CRF-24, 26, 27 target text unchanged since the base. CRF-28 kept at P4 (keep argument: squash merge makes the title the permanent commit subject; drop argument considered: "workspace" qualifies it). Result: 3 P4 posted; 4 out of scope. Reviewed against 5393f9d..d6d24fb. Round 3Churn guard PROCEED: CRF-20 and CRF-22 fixed in 08ac54f, CRF-28 fixed by retitle. Inventory validation: dropped and out-of-scope rows still hold (CRF-9's comment gained a sentence, which strengthens its drop reason; title type still refactor). Author comment IC_kwDOGkVX1s8AAAABW5XHbw says the round 2 out-of-scope items predate the PR and stay unchanged; that is an author-agent statement, not a human ticket or acceptance. Netero (new agent, no contested findings): no findings; verified both fixes and ran stories (23/23). Fix round (delta: one story assertion, one comment). Panel: ging-ts, ging-react, nami (triggers on changed .ts/.tsx), gon (comment changed), leorio (new commit message), wildcard chopper (random draw). All new agents. Cross-check: ging-ts, ging-react, nami, chopper reported no in-scope findings. CRF-30 dropped (keep argument: a hook comment naming a view control goes stale if the view changes; drop reason: the round 2 review prescribed this sentence and Result: no in-scope findings; all prior findings resolved. APPROVE (tool downgrades to COMMENT). Reviewed against 5393f9d..08ac54f. About deep-reviewCRF = Coder Review Finding (P0-P4, Nit, Note)
|
There was a problem hiding this comment.
This PR removes the "Jump to workspace" rows from the Workspaces filter dropdown and the search-result support from FilterCombobox. Findings: 2 P3, 5 P4, 1 Nit.
Out of scope (needs a ticket or explicit acceptance by a human):
site/src/components/Filter/FilterCombobox/FilterCombobox.tsx:29: the doc comment calls the generic component a "workspace filter input" and sits on the unexportedFilterComboboxPropstype, so readers may treat the component as workspace-specific and hoveringFilterComboboxshows no doc.site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:157: the hook doc calls it the "unified workspace filter combobox" and lists internals instead of the caller contract, so readers may treat the hook as workspace-specific.site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:643: the comment on thetypeaheadobject repeats the key name and the fields listed below it, adding words without information.
site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:601
P3 [CRF-1] The Tab-completion comment still describes "a highlighted resource preview", a row type this PR removes. (Netero)
After this PR the browsing list contains only category rows and value-suggestion rows, and Tab handles both at lines 614-626, so the comment explains a case that can no longer occur. Replace it with one line: Tab completes the highlighted category or value suggestion and otherwise moves focus.
🤖
site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:183
P4 [CRF-6] The PR description says the dropdown "does not open just to show workspace rows", but opening never depended on those rows. (Pariston)
open is mode !== "closed", and handleInputFocus and typeFreeText set mode to "browsing" before and after this PR, so the dropdown opens on focus and on every keystroke either way. What changes is its content: a name that matches no filter now shows "No filters found." instead of workspace rows. Correct that sentence so readers do not expect a change in when the dropdown opens.
🤖
site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:326-359
P4 [CRF-7] The PR description calls the removed feature "preview support", but FilterCombobox keeps a different feature with that name: category row previews (categoryPreviews, CategoryPreviewText, previewOptions in these lines). (Leorio)
A reader who sees "removes the generic preview support ... the preview query and loading and error handling" and then finds previewOptions still queried here cannot tell from the description whether the removal is complete. The removed code called itself search results (SearchResult, getSearchResults, searchResultsQuery). Use that name in the description and state that category row previews are unchanged.
🤖
🤖 This review was automatically generated with Coder Agents.
…f the two-source typeahead
|
Review-body findings:
|
|
/coder-agents-review |
There was a problem hiding this comment.
This round reviews d6d24fb. Findings: 3 P4.
Fixed and verified: the stale Tab comment, the error-label alias, the close parameter, the repeated loading conditions, the FilterComboboxItem doc, and both PR description corrections. The "No filters found." finding for name searches is closed: the description now documents the behavior, and the stacked PR #29426 test "emits unmatched typed text without selecting a filter" exists at FilterCombobox.test.tsx:160.
Out of scope (needs a ticket or explicit acceptance by a human):
site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:374:typeaheadErrorrepeatsactiveCategoryKey === null && isBrowsing, whichtypeaheadActivedefines on the next line (the base had the same repetition undersuggestionsError), so the two definitions of an active typeahead can drift.site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:119: thederiveStatusMessagecomment says "each terminal state", but the function also returns loading text, so the comment misdescribes its output.site/src/components/Filter/FilterCombobox/FilterCombobox.tsx:332: "No filters found" is written three times, twice with a period (FilterCombobox.tsx:332,:439) and once without (useFilterCombobox.ts:146), so the visible and announced text can drift apart.site/src/components/Filter/FilterCombobox/FilterCombobox.tsx:413: the category error uses a curly apostrophe (Couldn’t) whileSUGGESTIONS_ERROR_MESSAGEand the live-region text use a straight one, so the two popup errors render different apostrophes.
site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:326-359
P4 [CRF-28] The PR title still calls the removed feature "workspace previews", while FilterCombobox keeps a feature named previews (categoryPreviews, CategoryPreviewText, previewOptions in these lines). (Leorio)
The description now says search results, but the repository squash-merges, so the title becomes the only commit subject on main and a reader of git log meets the ambiguity the description fix removed. Retitle to refactor(site): remove workspace search results from the filter combobox, which matches the removed identifiers (SearchResult, getSearchResults).
🤖
🤖 This review was automatically generated with Coder Agents.
…eview of the workspace search result removal
|
CRF-28: retitled to The four out-of-scope notes from review 5316715693 (the repeated active-typeahead condition, the
|
|
/coder-agents-review |
There was a problem hiding this comment.
This round reviews 08ac54f. No new findings.
Fixed and verified: CrossCategoryValueSuggestions now asserts the input is empty after picking a value suggestion, the comment above typeaheadLoading now explains the !typeaheadError term and matches the code, and the title now says search results. All findings from earlier rounds are resolved.
The out-of-scope items from earlier rounds and the one below still need a human to file a ticket or accept them.
Out of scope (needs a ticket or explicit acceptance by a human):
site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:382: no story covers one category query failing while another is still fetching (TypeaheadErrorRetryhas one category), so removing!typeaheadErrorwould likely still pass every story while showing a spinner instead of the error and Retry. The base had the same gap undervalueSuggestionsLoading.
🤖 This review was automatically generated with Coder Agents.
…box-remove-workspace-previews # Conflicts: # site/src/components/Filter/FilterCombobox/FilterCombobox.tsx # site/src/components/Filter/FilterCombobox/types.ts # site/src/pages/WorkspacesPage/filter/WorkspacesFilter.tsx
Summary
Removes the "Jump to workspace" previews from the Workspaces filter. Typing free text no longer lists up to five matching workspaces in the dropdown that you can click to open.
Typed text still searches workspaces by name: it is committed to the filter query and narrows the workspace table as before. The dropdown now only offers filters (categories and matching values), so it stays about filtering rather than mixing in navigation. It still opens on focus and while typing. For a name that matches no filter, the dropdown now shows "No filters found." in place of workspace rows, and the table is still filtered by the name.
Removes the generic search-result support from
FilterComboboxas well, since Workspaces was its only caller: thegetSearchResults,onSearchResultSelect, andsearchResultsLabelprops, theSearchResulttype, the search-results query with its loading and error handling, and the related stories. Category row previews (categoryPreviews) are unchanged here.Split out of #29426 so this product change can be reviewed on its own.
Why remove rather than keep: the workspace rows added noise to a dropdown that should be about filters, and the component has only been dogfooded internally and has not shipped in a release, so no users lose a feature they rely on.
Generated with Coder Agents on behalf of @tracyjohnsonux.