Repository navigation
feat(site/src): add an Owner scope toggle for shared workspaces - #29872
Conversation
… tooltip to its two lines
…on once three chips are applied
…ouse-interactions # Conflicts: # site/src/components/Filter/FilterCombobox/FilterCombobox.stories.tsx # site/src/components/Filter/FilterCombobox/FilterCombobox.tsx # site/src/components/Filter/FilterCombobox/filterQuery.ts # site/src/components/Filter/FilterCombobox/primitives.tsx # site/src/components/Filter/FilterCombobox/types.ts # site/src/components/Filter/FilterCombobox/useFilterCombobox.ts # site/src/pages/WorkspacesPage/filter/WorkspacesFilter.stories.tsx # site/src/pages/WorkspacesPage/filter/WorkspacesFilter.tsx # site/src/pages/WorkspacesPage/filter/categoryOptions.tsx
|
/coder-agents-review |
|
Chat: Review posted | View chat Review history
deep-review v0.13.0 | Round 22 | Last posted: Round 22, 137 findings (8 P2, 33 P3, 63 P4, 33 Nit), APPROVE. Review Finding inventoryFinding inventory: PR #29872Findings
Law analysisR5: effective +1227 -152 (13 files; 605 production, 622 test). Head 7ed2266. Verdict: Don't split. Enforcement: Advisory. Valid vertical cut exists (slice B: scope-phrase typeahead, about 80 production lines) but splitting at round 5 costs more review than it saves; the unreviewed base-merge focus change in R15: effective +1811 -129 (13 files; 634 production, 1177 test). Head 9a045a4. Verdict: Don't split. Enforcement: Advisory. Production grew 29 lines since R5; the rerun was triggered by test growth. Slice B (scope-phrase typeahead, about 100 production / 230 test) is still a valid vertical cut but depends on the scope toggle and Workspaces adoption, and splitting at round 15 would re-thread Contested and acknowledgedCRF-8 (P2, categoryOptions.tsx:-161) - Author accepted R5
CRF-12 (P3, useFilterCombobox.ts:288) - Acknowledged R4
CRF-8 (P2, categoryOptions.tsx:-161) - Removing the Shared attribute drops the any-sharing filter
CRF-10 (P3, useFilterCombobox.ts:272) - No-chip switch state depends on removal history
CRF-12 (P3, useFilterCombobox.ts:288) - Switch on by default
CRF-13 (P3, WorkspacesFilter.tsx:69) - Pill text reads as a narrowing condition
CRF-14 (P3, WorkspacesFilter.tsx:67) - No-chip switch label
CRF-15 (P3, FilterCombobox.tsx:408) - Truncated pill text on touch and keyboard
CRF-72 (P3, docs/user-guides/shared-workspaces.md:85) - User guide still says to filter for "Shared"
Round logRound 1Full panel (round 1). Netero first pass: 2 P2, 2 P3, 1 P4, 1 Nit, 1 Note; no P0, so the panel ran. Law not spawned (effective additions 588, under 1000). Panel: ging-ts, ging-react, nami, luffy, melody (domain specialists), pariston, mafuuu (core), bisky (tests changed), gon, leorio (once-per-PR floor, round 1 placement), meruem (wildcard, random draw from the distilled set). Size target for a focused TypeScript PR is 6 to 8; the five triggered specialists plus core and Bisky reach 8, and Gon and Leorio were added for their round 1 floor. Cross-check:
Reviewed against 5c717b1..74472cd. Round 2BLOCKED. Churn guard: 21 addressed, 1 contested (CRF-8, author reply PRRC_kwDOGkVX1s70fPyg), 5 silent (CRF-10, CRF-12, CRF-13, CRF-14, CRF-15). The author's follow-up comment IC_kwDOGkVX1s8AAAABW7ECMA lists the five as "Still open for an author decision" with no reasoning or ticket, which the churn guard rules classify as silent. No Netero, no panel. Addressed statuses record the author's claimed fix commits; the panel has not verified them. The PR base moved to 19fe0bf (stacked on #29876); effective additions grew 588 to 1000, below the Law threshold. The same follow-up comment answers the round 1 out-of-scope items: CRF-40 belongs to the base redesign (#29426), CRF-41 ( Reviewed against 19fe0bf..ab755ae. Round 3Churn guard: PROCEED. CRF-8 contested; CRF-10, CRF-12 to CRF-15 deferred with #29912 items 1 to 5 (issue verified open by the churn guard). Head unchanged since round 2 (ab755ae), but round 2 ran no reviewers, so Netero ran: 2 P3, 4 P4, 1 Nit (advisory, post-panel round). Law not spawned (effective additions 1000, not above 1000; growth since round 1 is 412). Restructure round: files added to the diff since the last panel round ( Cross-check:
Post result: 17 inline comments (filterQuery.ts:52 for CRF-58 and types.ts:24 for CRF-65 folded into the body) and 4 replies. All three Reviewed against 19fe0bf..ab755ae. Round 4BLOCKED. Churn guard: 4 addressed (CRF-10, CRF-13, CRF-14, CRF-15 in 886074f), 1 acknowledged (CRF-12, author decision to keep the default on; the reply does not engage the batch-action consequence, and no panel has evaluated it), 23 silent (CRF-8 re-raise, CRF-18 re-raise, CRF-45 to CRF-65). No Netero, no panel. Timing: 886074f was committed at 14:45:17Z, before the round 3 review posted at 14:47:29Z; the author's replies (14:50:27Z to 14:50:39Z) answer the #29912 items, and The round 3 log asked to treat CRF-52, CRF-53, and the CRF-18 re-raise as not seen; the churn guard has no such status and classified them silent, and the verdict is BLOCKED without them. The round 4 body restates all three in full, plus CRF-58 and CRF-65, which have no thread because round 3 folded them into its body. Reviewed against 19fe0bf..886074f. Round 5Churn guard: PROCEED. 22 addressed in 7ed2266 (CRF-18, CRF-45 to CRF-65), CRF-8 accepted by the human author on its thread, zero silent. Netero ran (post-panel round): 1 P2, 1 P3, 1 Note. Law ran (effective additions 1227, above 1000): Don't split, Advisory, 1 P3 (CRF-74). Full panel: the base moved to d15c0c7 (merge of #29876 updates, including the primitives.tsx focus change) and effective additions grew from 1000 to 1227 since the last panel round. Panel: ging-ts, ging-react, nami, luffy, melody (specialists), pariston, mafuuu (core), bisky (tests), gon, leorio (naming and docs changed), knov (wildcard, random draw from the distilled set). Ging TS and Ging React: no findings. Cross-check:
Placement: CRF-71 and CRF-75 are posted inline on their own lines, not as replies on the resolved CRF-52 thread (vault: resolved threads hide replies); the body names them as new evidence against the mixed-query fix. Post result: review 5322464645 (COMMENT), 11 inline comments; CRF-72 ( Reviewed against d15c0c7..7ed2266. Round 6BLOCKED. Churn guard: 11 addressed in 0ea86e5 (CRF-71, CRF-74 to CRF-82, CRF-84), 1 silent (CRF-72). No Netero, no Law, no panel. The addressed statuses record the author's claimed fixes; no reviewer has verified them. CRF-72: the author comment IC_kwDOGkVX1s8AAAABXBJecQ defers the CRF-73 (Note (body)): the same comment says one chip per key is restored, so a repeated 0ea86e5 replaces the kept-search-text approach with a second plain chip, removes the Post result: review 5322791094 (COMMENT), body only. Reviewed against 0b1bba8..81773d0. Round 7Churn guard: PROCEED. CRF-72 deferred to #29955 (open, names line 85 and the screenshot; checked through the public API because Restructure round: 0ea86e5 (unreviewed, round 6 was blocked) removed the Cross-check:
Post result: review 5323286244 (COMMENT), 18 inline comments, no replies. Reviewed against 4cb81dc..f33837c. Round 8Churn guard: PROCEED. 18 addressed in 64dbfce (CRF-90 to CRF-107), CRF-72 deferred to #29955. Head 64dbfce; base moved to d592615. Netero ran (post-panel round): 1 P4 (CRF-112). Law not spawned: effective additions 1344, growth 117 since round 5. Fix round: 64dbfce only fixes round 7 findings. The hook's return shape changed ( Cross-check:
Post result: review 5323550583 (COMMENT), 7 inline comments, no replies. Reviewed against d592615..64dbfce. Round 9Churn guard: PROCEED. 7 addressed in 5dab005 (CRF-112 to CRF-118), CRF-72 deferred to #29955 (open). Head 5dab005; base moved to 6353285. Netero ran (post-panel round): 1 P3, 1 P4 (CRF-127, CRF-128). Law not spawned: effective additions 1412, growth 185 since round 5. The author answered the round 8 out-of-scope items: CRF-122 predates the PR and carries Fix round: 5dab005 only fixes round 8 findings (+163 -76 in 4 files). Panel: personas that raised open findings the commit touches (mafuuu, melody, nami for CRF-113; leorio, gon for CRF-114, CRF-116, CRF-118; bisky for CRF-115; razor for CRF-117), ging-ts and ging-react for the changed Cross-check:
Post result: review 5323734896 (COMMENT), 6 inline comments, no replies. Reviewed against 6353285..5dab005. Round 10Churn guard: PROCEED. CRF-127 to CRF-132 addressed in 92c95ec, CRF-72 deferred to #29955, none silent. Head ce9e642; base 200e857. Netero ran (post-panel round): 1 P3, 2 P4 (CRF-140 to CRF-142). Law not spawned: effective additions 1519, growth 292 since round 5. Fix round: 92c95ec only fixes round 9 findings (+143 -37 in 4 files); the other new commits merge the #29876 base. Panel: personas that raised open findings the commit touches (melody, razor for CRF-127; chopper for CRF-129; bisky, mafuuu for CRF-130; leorio for CRF-131; gon for CRF-132), ging-ts and ging-react for the changed Cross-check:
Post result: review 5324028773 (COMMENT), 8 inline comments, no replies. Reviewed against 5dab005..ce9e642. Round 11Churn guard: PROCEED. CRF-140 to CRF-147 addressed in 3302857, CRF-72 deferred to #29955, none silent. Head 3302857; base 4083105. Netero ran (post-panel round): 1 P4 (CRF-150). Law not spawned: effective additions 1579, growth 352 since round 5. Fix round: 3302857 only fixes round 10 findings (+89 -29 in 4 files); the other new commits merge the #29876 base, and the merge resolutions only list the base's Cross-check:
Post result: review 5324223263 (COMMENT), 3 inline comments, no replies. Reviewed against ce9e642..3302857. Round 12Churn guard: PROCEED. CRF-150 to CRF-152 addressed in cee3c66, CRF-72 deferred to #29955, none silent. Head cee3c66; base b25c4ac. Netero ran (post-panel round): 1 P4 (CRF-159). Law not spawned: effective additions 1586, growth 359 since round 5. Fix round: cee3c66 only fixes round 11 findings (+42 -35 in 3 files); the other new commits merge the #29876 base, and the merge resolutions keep both sides (the base's Cross-check:
Post result: review 5324372078 (COMMENT), 4 inline comments; CRF-162 at Reviewed against 3302857..cee3c66. Round 13Churn guard: PROCEED. CRF-159 to CRF-163 addressed in e3352f4 (CRF-162 had no thread because Fix round: e3352f4 only fixes round 12 findings (+166 -40 in 3 files), including moving Cross-check:
Post result: review 5324557962 (COMMENT), 6 inline comments, no replies. Reviewed against cee3c66..7d90727. Round 14Churn guard: PROCEED. CRF-168 to CRF-173 addressed in 458fbb9, none silent. CRF-176 (out of scope) got no reply; out-of-scope items do not block. Head 8baceb7; base 9c006d2. Netero ran (post-panel round): 1 P3, 1 Nit (CRF-181, CRF-182). Law not spawned: effective additions 1725, growth 498 since round 5. Fix round: 458fbb9 only fixes round 13 findings (+33 -33 in 3 files); the other new commits merge the #29876 base, whose Cross-check:
Post result: review 5324744454 (COMMENT), 5 inline comments, no replies. Reviewed against 7d90727..8baceb7. Round 15Churn guard: PROCEED. CRF-181 to CRF-185 addressed in 8a1ce33 and 9a045a4, none silent. Head 9a045a4; base c0e978f. Netero ran (post-panel round): 1 P4 (CRF-192). Law ran: effective additions 1811, growth 584 since round 5 (above 500); verdict Don't split, Advisory. Fix round: 8a1ce33 and 9a045a4 only fix round 14 findings; the other new commits merge the #29876 base (merge resolution in 6f17796 read by Netero and Melody). Panel: nami, gon, leorio, razor, mafuuu (the round 14 raisers of CRF-181, CRF-183, CRF-184, CRF-185), ging-ts and ging-react for the changed Cross-check:
Post result: review 5324967231 (COMMENT), 5 inline comments, no replies. Reviewed against 8baceb7..9a045a4. Round 16Churn guard: PROCEED. CRF-192 to CRF-196 addressed in 710a26d, CRF-72 deferred to #29955, none silent. The churn guard called every other new commit a base commit; 02631cd (typed-Enter wording in Inventory validation: CRF-197 reopened, because 710a26d makes Fix round: 710a26d fixes round 15 findings and 02631cd rewords two comments; merges d079c80 and 2fc73a2 bring the #29876 base (d079c80 resolved a conflict in Cross-check:
Post result: review 5325153009 (COMMENT), 8 inline comments, no replies. Reviewed against 9a045a4..2fc73a2. Round 17Churn guard: PROCEED. CRF-201 to CRF-205 and CRF-207 to CRF-209 addressed (43743c8; CRF-207 by a PR description edit), CRF-72 deferred to #29955 (the churn guard's Inventory validation: no non-posted disposition depends on code 43743c8 or the c69eaf1 merge resolution changed. Fix round: 43743c8 only answers round 16 findings (comments moved and reworded, one test changed); merges ec6944f and c69eaf1 bring the #29876 base (c69eaf1 resolved a conflict in Cross-check:
Post result: review 5325230124 (COMMENT), 1 inline comment, no replies. Reviewed against 2fc73a2..43743c8. Round 18Churn guard: PROCEED. CRF-221 addressed in 2d06c84; CRF-72 deferred to #29955 ( Inventory validation: no non-posted disposition depends on the rewrapped comment or the merged base lines (Netero checked the same). Fix round: 2d06c84 only rewraps the Cross-check:
Post result: review 5325309053, posted in APPROVE mode with no inline comments (the CLI output does not show whether GitHub recorded APPROVE or the COMMENT downgrade). Dismissing the earlier REQUEST_CHANGES review failed: Reviewed against 43743c8..2d06c84. Round 19Churn guard: PROCEED. No PR-only commits since round 18; CRF-72 deferred to #29955 ( Inventory validation: the PR's own Fix round with no PR commits: merges 9141926 and c43b205 bring the #29876 base; 9141926 resolved a conflict in Cross-check:
Post result: review 5325600359, posted in APPROVE mode with no inline comments. Dismissing the earlier REQUEST_CHANGES review failed again with the 403 integration error. Reviewed against 2d06c84..c43b205. Round 20Churn guard: PROCEED. No open findings besides CRF-72 (deferred to #29955; Inventory validation: no non-posted disposition depends on the self-row change. CRF-137 and CRF-180 (permission-set tests) use an empty query, for which the self row is unchanged; the vault note on typing one's own username still holds, because the label contains the username. Fix round: 53e9abf is a one-line production change plus a test. Not a restructure (no files added or moved, no signature change, same goal, growth 8). Panel: ging-ts and ging-react for the changed Cross-check:
Post result: review 5325651430 (COMMENT), 3 inline comments, no replies. CRF-234 at Reviewed against c43b205..9237e4d. Round 21Churn guard: PROCEED. CRF-232 to CRF-235 addressed in PR-only commit f8773ec (3 files, +26/-8); no silent items. CRF-72 deferred to #29955 ( Inventory validation: f8773ec changes only Fix round, not a restructure. Panel: gon (comment and name changes), leorio (CRF-234 and CRF-235 raiser, story rename), zoro (CRF-235 Nit raiser), bisky (new test), ging-ts and ging-react (changed Cross-check:
Post result: review 5325715032 (COMMENT), 1 inline comment (CRF-241 at Reviewed against 9237e4d..f8773ec. Round 22Setup restart: the first Churn guard: PROCEED. CRF-241 addressed in PR-only commit 1142d5e (one line, the test name); no silent items. CRF-72 deferred to #29955 ( Inventory validation: 1142d5e changes only a test name; no non-posted disposition depends on it. Fix round, not a restructure (one-line test rename, no files added or moved, no signature change, same goal, growth 0). Panel: gon and leorio (raised CRF-241, whose line the commit changes), ging-ts ( Cross-check:
About deep-reviewCRF = Coder Review Finding (P0-P4, Nit, Note)
|
There was a problem hiding this comment.
This PR replaces the User category on /workspaces with an include-shared switch on the Owner category, adds a scope pill and a shared typeahead, and removes the Shared attribute. Findings: 4 P2, 13 P3, 4 P4, 6 Nit.
Out of scope (needs a ticket or explicit acceptance by a human):
site/src/components/Filter/FilterCombobox/useFilterCombobox.ts:957: with the menu open, Enter on a category row matched by typed text (for examplestafor Status) opens that category and clears the free-text search, so a search that starts with a category name cannot be submitted with Enter.site/src/components/Filter/FilterCombobox/filterQuery.ts:29:categoryPreviewhas no production caller and builds tokens fromcategory.key, so it would not matchuser:chips if it were used again.coderd/searchquery/search.go:283: the workspace query language has no OR, so "owned by or shared with" needs the fuseduser:key and a frontend key rewrite instead of a composable filter.site/src/pages/WorkspacesPage/filter/WorkspacesFilter.tsx:53: "Users who cannot list others only see themselves." repeats the TODO above it; the repetition predates this PR.
Notes:
- Existing
shared:trueURLs now render as free text instead of a chip. The backend still applies the filter. scopeToggleis a genericFilterComboboxoption with one consumer, and about 360 lines of production code inFilterCombobox.tsxanduseFilterCombobox.tsserve it.
site/src/components/Filter/FilterCombobox/types.ts:14
P3 [CRF-4] The token doc comment still lists shared:true as an Attributes token, and no category commits it after this PR. (Netero)
Replace the example with the two remaining tokens, outdated:true and dormant:true.
🤖
site/src/pages/WorkspacesPage/filter/categoryOptions.tsx:99
Nit [CRF-28] Two comments in categoryOptions.tsx still describe separate User and Owner categories. (Melody, Luffy)
Lines 99 and 100 ("so the User and Owner categories stay available") and line 118 ("Shared by the User and Owner categories") now describe one Owner category with the owner and user keys. Update both to match the comment at WorkspacesFilter.tsx:51.
🤖
🤖 This review was automatically generated with Coder Agents.
…o fix/filter-combobox-mouse-interactions # Conflicts: # site/src/components/Filter/FilterCombobox/FilterCombobox.tsx # site/src/components/Filter/FilterCombobox/queries.ts # site/src/components/Filter/FilterCombobox/types.ts # site/src/components/Filter/FilterCombobox/useFilterCombobox.ts
…ut of the filter redesign
…on once three chips are applied
…ox-owner-shared-scope
…r-combobox-hide-single-option # Conflicts: # site/src/components/Filter/FilterCombobox/useFilterCombobox.ts
…er-combobox-clear-all
…ox-owner-shared-scope # Conflicts: # site/src/components/Filter/FilterCombobox/FilterCombobox.tsx # site/src/components/Filter/FilterCombobox/filterQuery.ts # site/src/components/Filter/FilterCombobox/useFilterCombobox.ts
…ry's category listed
…er-combobox-clear-all
…ox-owner-shared-scope
…r-combobox-hide-single-option # Conflicts: # site/src/components/Filter/FilterCombobox/types.ts # site/src/components/Filter/FilterCombobox/useFilterCombobox.ts
|
CRF-234 fixed in f8773ec: renamed the story to
|
|
/coder-agents-review |
There was a problem hiding this comment.
This PR merges the User and Owner workspace filters into one Owner category with a shared-scope switch. This round: 1 Nit.
f8773ec fixes the four round 20 findings: the {username} (you) row stays listed when the users API returns the current user, the story comment is wrapped, the story is renamed to OrdinaryUserSeesOwner, and the getSelfUserFilterOptions comment states its match rule.
🤖 This review was automatically generated with Coder Agents.
…n the current user option test
|
/coder-agents-review |
There was a problem hiding this comment.
This PR merges the User and Owner workspace filters into one Owner category with a shared-scope switch. This round: no new findings.
1142d5e fixes the round 21 finding: the test name now states that it covers the label match used when the users API does not return the current user. No in-scope finding from earlier rounds remains open; the user guide update is tracked in #29955.
🤖 This review was automatically generated with Coder Agents.
…box-remove-workspace-previews # Conflicts: # site/src/components/Filter/FilterCombobox/FilterCombobox.tsx # site/src/components/Filter/FilterCombobox/types.ts # site/src/pages/WorkspacesPage/filter/WorkspacesFilter.tsx
…workspace-previews' into fix/filter-combobox-mouse-interactions # Conflicts: # site/src/components/Filter/FilterCombobox/FilterCombobox.tsx # site/src/components/Filter/FilterCombobox/primitives.tsx # site/src/components/Filter/FilterCombobox/useFilterCombobox.ts
…r-combobox-hide-single-option
…-option' into feat/filter-combobox-clear-all # Conflicts: # site/src/components/Filter/FilterCombobox/primitives.tsx
…into feat/filter-combobox-owner-shared-scope # Conflicts: # site/src/components/Filter/FilterCombobox/primitives.tsx # site/src/components/Filter/FilterCombobox/types.ts # site/src/pages/WorkspacesPage/filter/categoryOptions.tsx
…ouse-interactions # Conflicts: # site/src/components/Filter/FilterCombobox/FilterCombobox.stories.tsx # site/src/components/Filter/FilterCombobox/FilterCombobox.tsx # site/src/components/Filter/FilterCombobox/queries.ts # site/src/components/Filter/FilterCombobox/types.ts # site/src/components/Filter/FilterCombobox/useFilterCombobox.ts
…ptions as buttons
…nline options (#29426) ## Summary Improves mouse and touch interactions for the workspace FilterCombobox while preserving its keyboard navigation. The filter control (icon only) now opens a compact main menu with inline status and workspace-state options, pointer flyouts for Owner, User, Template, and Organizations, and a single-panel mobile flow. Applied chips always render lowercase. Selected workspace attributes remain single-select to match the existing workspace filtering UI. Stacked on #29874 (removes the workspace result previews). Follows #29111, which has merged. Split out and stacked on this PR: #29875 (hide single-option categories), #29876 (Clear all), and #29872 (Owner shared workspaces toggle). <details> <summary>Implementation notes</summary> - Keeps Up/Down, ArrowRight, ArrowLeft, Backspace, Escape, and Tab keyboard behavior. Free-typed text no longer highlights the first row: Enter applies it as a search and closes the menu, while arrow keys, Home/End, cmdk's Ctrl+N/J/P/K, or the pointer pick a filter row. Tab still completes the top row, and a typed `key:` prefix, the category view, and the all-filters list keep the first match highlighted. - Enter activates any focused button in the combobox (Filters, flyout options, Retry, chip remove) through one `FilterComboboxRoot` handler. - The menu's height is bounded only by the viewport, so it scrolls only when it cannot fit. - Uses right-opening pointer flyouts with hover forgiveness and searchable, scrollable long lists. The flyout follows the cmdk highlight, so keyboard navigation closes or switches it, and it resets whenever the menu opens or closes. - Inline categories (Status, Workspace attributes) never enter category mode; a typed `status:` prefix narrows the inline group in place and is withheld from the workspace search query. A failed inline load shows its error and Retry under the category heading, since inline categories have no flyout. - Browsing and category mode share one main-panel renderer. - Uses a persistent full-width mobile panel with touch scrolling. While open on mobile the field pins below the navbar with CSS (`fixed`), with no JS scroll positioning. Verified in Chrome device emulation, not yet on a physical device with a software keyboard. - Keeps free-text workspace searches separate from matching filter-option text, including text typed before a `status:` prefix. Typed text that could still match a filter (a category name, a loaded option, or an option the category's search returns) is held back from the workspace search, so results do not empty out mid-word. It is applied when no lookup finds a match (a failed lookup counts as no match, and the wait stops after 1s), on Enter, or when the menu is dismissed or switched to all filters. The menu shows no separate cue for held-back text; the author (@tracyjohnsonux) decided this, and also rejected a `Search workspaces for "..."` row. That is why Enter-search is built by suppressing cmdk's automatic first-row highlight (`userNavigatingRef` and the `""`/`" "` reset in `FilterComboboxRoot`) rather than by rendering a search row. Chip tokens in the typed text become chips when it is applied. - While typed text is debounced, loaded options are filtered locally so matching rows stay visible until the loader's results arrive. - Enter or Tab on an applied option that typed text located keeps it and clears the text. Clicking a checked row removes it. - Enter commits a typed inline value that is not a suggestion, such as `status:starting`. - Flyout searches go through the category loader, so owners beyond the first page are found. The search field stays mounted while results load, shrink, or are empty. - Clicking a category row narrowed by typed text enters the category, and focus returns to the input after picking a flyout option. - Keeps selected options visible with Coder-standard checkmarks and styling. - `FilterCategory.chipLabelOnly` marks categories whose chips show only the option label (Workspace attributes). Inline options load up front so those chips are labelled before the menu is first opened. - Pointer flyouts and category lists share one `OptionsPanel` shell (search header, list, empty state). </details> Generated by Coder Agents. --------- Co-authored-by: Jake Howell <jacob@coder.com> Co-authored-by: Jake Howell <jake@hwll.me>
…hide-single-option # Conflicts: # site/src/components/Filter/FilterCombobox/FilterCombobox.stories.tsx # site/src/components/Filter/FilterCombobox/FilterCombobox.test.tsx # site/src/components/Filter/FilterCombobox/FilterCombobox.tsx # site/src/components/Filter/FilterCombobox/primitives.tsx # site/src/components/Filter/FilterCombobox/types.ts # site/src/components/Filter/FilterCombobox/useFilterCombobox.ts
…clear-all # Conflicts: # site/src/components/Filter/FilterCombobox/FilterCombobox.stories.tsx # site/src/components/Filter/FilterCombobox/FilterCombobox.tsx # site/src/components/Filter/FilterCombobox/useFilterCombobox.ts
…owner-shared-scope # Conflicts: # site/src/components/Filter/FilterCombobox/FilterCombobox.stories.tsx # site/src/components/Filter/FilterCombobox/FilterCombobox.test.tsx
Summary
Replaces the separate User category on
/workspaces(from #29586) with an "Include workspaces shared with {owner}" switch in the Owner flyout, so one Owner category covers bothowner:anduser:.user:<name>(owned by or shared with that user). Once a chip is applied, the switch follows its key and later picks keep it. Turning the switch off commitsowner:<name>(owned by that user). Flipping it rewrites the applied chip in place. A typedowner:oruser:prefix sets the scope for that entry and reaches the query only when an option is picked. Without a typed prefix, an owner an applied chip holds, ignoring letter case, maps to that chip: selecting its option removes the chip (typed text highlights the first match, so Enter selects it), and typed Enter with no option highlighted keeps it. Otherwise a typed owner follows the switch when an option lists it; an unlisted owner goes underowner:unlessuser:was typed, because the backend rejectsuser:for users the requester cannot read (searchquery: user: filter rejects usernames the requester cannot read while owner: accepts them #29961).include sharedpill is joined to the Owner chip. The joined pill truncates on narrow widths so it stays inside the field, and hovering it shows the full switch label (for example, "Include workspaces shared with alice") on one line. Removing the pill (click, or Backspace on an empty input; screen readers hear "Hide workspaces shared with {owner}") turns the switch off. A second Backspace removes the Owner chip. Keyboard removal of the pill keeps focus in the search input.shared with owner(for examplesha) lists Owner and opens its flyout with the full list and the switch, until another row is highlighted. Picking an owner or flipping the switch there clears the typed text; text already applied as a search stays. Typinguseralso lists Owner.owner:and auser:token (such as a bookmarkeduser:me owner:alice) shows each chip under its own query key with no pill, so every edit keeps both. Selecting an owner that one of the chips holds, by click or by Enter on its highlighted row, removes that chip; typed Enter with no option highlighted keeps it. The switch is disabled in that state, because rewriting one chip to the other key would silently drop the other filter. A pick after a typedowner:oruser:prefix replaces the chip under that key.{username} (you)option is listed only when the typed text matches it (its label,me, or a users API match on name or email), like every other owner, so typing an unknown owner and pressing Enter commits that owner instead ofme.shared:true(any workspace with ACL entries) still works when typed.No backend change:
user:andowner:already exist incoderd/searchquery/search.go.Stacked on #29876 (Clear all), the last of the PRs split out of #29426 to keep that PR focused on the mouse and touch redesign.
Decision notes
user:<name>because filters combine with AND, soowner:me shared_with_user:mecannot express "owned by me OR shared with me". The switch keeps that distinction without a second category.shared:trueis not reused for the switch because it means "has any sharing", not "shared with this owner".user:mestays a chip.min-w-0and truncates, while the Owner chip does not shrink, so only the pill gives way at narrow widths.user:rejects usernames the requester cannot read) and site: filter menu does not expose applied options to screen readers #29962 (applied options are not exposed to screen readers, predates this PR).Generated with Coder Agents on behalf of @tracyjohnsonux.