Skip to content

feat(site): count every PR in the chats sidebar - #29832

Merged
DanielleMaywood merged 8 commits into
feat/chat-diff-ref-topbarfrom
feat/chat-diff-ref-ui
Oct 9, 2026
Merged

DanielleMaywood merged 8 commits into
feat/chat-diff-ref-topbarfrom
feat/chat-diff-ref-ui

Conversation

@DanielleMaywood

@DanielleMaywood DanielleMaywood commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Part 6 of 6. Depends on #29831. Supersedes #29547, which merged with a flattened head by mistake.

The chats sidebar and search results now count every PR in diff_statuses, not only the primary ref. A chat with one PR shows that PR's state icon and line stats, even when the primary ref is a newer branch without a PR. A chat with several PRs shows a PR count instead of a single state icon, with no line stats. Screen readers hear "N pull requests".

In the sidebar tree, the kebab menu and the right-click menu of a chat list its PRs in a group between "Copy" and "Archive agent". One PR is a direct link. Several PRs open an "N PRs" submenu. The entries use the same rows as the top bar PR menu. Viewers of a shared chat also see the links. PRs without a URL are not listed.

These menus replace the hover tooltip from earlier commits. The tooltip did not open on touch and had no links to the PRs.

Generated by Coder Agents.

@DanielleMaywood
DanielleMaywood marked this pull request as draft September 24, 2026 08:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T08:41:19.710165Z 4c65507 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@DanielleMaywood DanielleMaywood added the experimental Changes that might not necessarily be merged, until its approved to proceed with. label Sep 24, 2026
@DanielleMaywood
DanielleMaywood marked this pull request as ready for review September 24, 2026 08:37
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 24, 2026
@DanielleMaywood
DanielleMaywood force-pushed the feat/chat-diff-ref-ui branch 3 times, most recently from ce0f0a4 to ac79137 Compare September 25, 2026 08:59
@DanielleMaywood
DanielleMaywood requested a review from a team as a code owner September 25, 2026 08:59
@DanielleMaywood
DanielleMaywood force-pushed the feat/chat-diff-ref-ui branch 2 times, most recently from a1b523b to ddc10c9 Compare September 30, 2026 14:37
@DanielleMaywood
DanielleMaywood force-pushed the feat/chat-diff-ref-ui branch 2 times, most recently from 95eb7d6 to 5c6263c Compare October 1, 2026 09:59
@DanielleMaywood
DanielleMaywood force-pushed the feat/chat-diff-ref-ui branch 2 times, most recently from 842ed97 to fd89504 Compare October 6, 2026 08:28
The sidebar and the search results now follow the full PR list. A
chat with one PR shows that PR's state icon and line stats. A chat
with several PRs shows the PR count instead; one state icon cannot
represent the others. Hovering the icon lists every PR, one row per
PR, each with its state, number, and title.
Every mock data fixture now starts with mock: mockChat2DiffStatus,
mockOverflowDiffStatus, mockMultiPRChat, and mockDashboardValue.
The label and PR number derivations stay in the row where they
are used, named prNumber and label to match the top bar.
The sole-PR stats and the popover row labels ran as unbroken
blocks of declarations. Each derivation group now sits under its
own comment with a blank line between groups.
The sidebar tooltip that listed a chat's PRs could not hold links, grew without limit, and opened on every hover of the row. The PRs now sit in the chat's kebab and right-click menus as links, in a group above "Archive agent". One PR is a direct item. Several PRs sit in an "N PRs" submenu that scrolls. Viewers of a shared chat also see the links. PRs without a URL are not listed.
@DanielleMaywood
DanielleMaywood merged commit ff3fa22 into main Oct 9, 2026
34 of 54 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

experimental Changes that might not necessarily be merged, until its approved to proceed with.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants