Repository navigation
feat(coderd/x/chatd): add busy_behavior to message_agent - #29786
ethanndickson wants to merge 1 commit into
Conversation
654faa9 to
957ff9f
Compare
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
957ff9f to
298e10b
Compare
298e10b to
2fd839a
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2fd839a to
85bbf06
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85bbf06dd4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Not fixing. This only matters if a |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Superseded by the new stack starting at #30073. The After discussing CODAGT-1191, the design changed: |
Closes CODAGT-1140
This swaps the
interruptboolean on themessage_agenttool for abusy_behaviorargument (queue,steerorinterrupt), so a parent agent can now steer a busy child without cancelling its current work. Leaving it out still meansqueue, andinterruptdoes whatinterrupt: trueused to.If a model still sends
interrupt, it's ignored and we fall back toqueue. That also applies to an oldmessage_agentcall that chatd reruns from history after an upgrade, but that needs the server to stop in the few milliseconds between committing the call and its result, and the message still gets delivered, just queued. I don't think that's worth a compatibility shim.