Skip to content

feat: add steer busy behavior to the chat API - #29785

Closed
ethanndickson wants to merge 1 commit into
ethanndickson/chat-steer-deliveryfrom
ethanndickson/chat-steer-api
Closed

ethanndickson wants to merge 1 commit into
ethanndickson/chat-steer-deliveryfrom
ethanndickson/chat-steer-api

Conversation

@ethanndickson

@ethanndickson ethanndickson commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Adds the steer busy behavior to POST /api/v2/chats/{chat}/messages and to the coder_send_chat_message tool of the Coder MCP server. When the chat is busy, a steer message reaches the model before the next model call of the running turn, and it does not cancel the request in flight. An idle chat receives the message at once, as with the other values. An unknown value returns 400.

Queued messages now include busy_behavior in the API responses and in the queue_update stream event, so clients can see when each queued row will be delivered.

The web UI sends no busy_behavior, so it keeps the default queue. Under site/, only the generated types and test fixtures change.

Part of CODAGT-1140

@ethanndickson

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T06:53:31.683082Z b18137d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4799f66137

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread coderd/exp_chats.go Resolved
Comment thread codersdk/chats.go Resolved
@linear-code

linear-code Bot commented Sep 23, 2026

Copy link
Copy Markdown

CODAGT-1140

@ethanndickson
ethanndickson force-pushed the ethanndickson/chat-steer-api branch 2 times, most recently from 1e09765 to 24ea9d3 Compare September 24, 2026 05:30
@ethanndickson

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24ea9d36a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codersdk/chats.go Resolved
@ethanndickson

Copy link
Copy Markdown
Member Author

@codex review

re: Promote steer rows before compaction model calls

Intended. Steer rows target the next assistant call, and compaction does not answer the user. Promoting before compaction would not change what the model sees: compaction keeps the trailing unanswered user rows out of the summary input and repeats them after the summary. Here, the first action after compaction is generate_assistant, and beginAssistantAttempt promotes the steer before that call. So the model gets "summary, then steer" either way, and history does not get a model-only copy of the steer.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 24ea9d36a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ethanndickson
ethanndickson marked this pull request as ready for review September 24, 2026 06:53
@ethanndickson
ethanndickson force-pushed the ethanndickson/chat-steer-api branch from 24ea9d3 to b18137d Compare September 25, 2026 05:44
@ethanndickson
ethanndickson requested a review from a team as a code owner September 25, 2026 05:44
@ethanndickson

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: b18137d4aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ethanndickson

Copy link
Copy Markdown
Member Author

Superseded by the new stack starting at #30073. The API changes will follow in a later PR of that stack.

After discussing CODAGT-1191, the design changed: steer becomes the default busy behaviour, interrupt is no longer a send option (interrupt, then send), and steer messages skip ahead of queued messages instead of pulling them into history early. That was enough change that I rebuilt the stack from main instead of rebasing this one.

@github-actions github-actions Bot locked and limited conversation to collaborators Sep 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants