Repository navigation
chore(coderd): store busy behavior on queued chat messages - #29783
ethanndickson wants to merge 2 commits into
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb5f533f61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84a578335c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review re: Replace the architecture prose with TODOs This misreads the guardrail. It stops agents from writing architecture updates on their own and has them leave TODOs so the human author writes the update instead. The author owns the text either way. I asked for this change and picked the wording, so this is the author's update, which is what the rule is for. Swapping it for TODOs would leave the spec stale, which is the problem your previous comment raised. I'll make the AGENTS.md wording clearer in a separate PR so author-approved prose isn't flagged again. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
84a5783 to
c82131e
Compare
c82131e to
ca74fb5
Compare
|
Superseded by #30073. After discussing CODAGT-1191, the design changed: |
Queued chat messages now record their busy behavior. The next PR in this stack adds
steer, and the generation loop then needs the behavior of each queued row to decide which rows are due before the next model call.The migration adds the Postgres enum
chat_busy_behavior(queue,steer,interrupt) and the columnchat_queued_messages.busy_behavior. The column isNOT NULL DEFAULT 'queue', so existing rows getqueue.InsertChatQueuedMessageWithCreatorstores the behavior of each new row.chatd now uses the generated
database.ChatBusyBehaviorinSendMessageInputandSendMessageOptions. This PR removeschatd.SendMessageBusyBehavior,chatstate.BusyBehavior, and thebusyBehaviorToChatStatebridge, so Go keeps only two busy behavior enums:database.ChatBusyBehaviorandcodersdk.ChatBusyBehavior.This PR does not change behavior.
SendMessagestill rejectssteer.Part of CODAGT-1140