Repository navigation
Conversation
pawbana
force-pushed
the
pawel/aigov-615-reverse-proxy-handler-with-recorder-lifecycle-and-key-2
branch
19 times, most recently
from
September 23, 2026 14:34
e718154 to
7ca2815
Compare
pawbana
force-pushed
the
pawel/aigov-615-reverse-proxy-handler-with-recorder-lifecycle-and-key-3
branch
5 times, most recently
from
September 23, 2026 15:14
eb687de to
81f64a5
Compare
pawbana
force-pushed
the
pawel/aigov-615-reverse-proxy-handler-with-recorder-lifecycle-and-key-3
branch
from
September 23, 2026 15:26
81f64a5 to
5f56ab9
Compare
pawbana
force-pushed
the
pawel/aigov-615-reverse-proxy-handler-with-recorder-lifecycle-and-key-3
branch
from
September 23, 2026 15:29
5f56ab9 to
06bbc31
Compare
pawbana
marked this pull request as ready for review
September 24, 2026 11:47
pawbana
force-pushed
the
pawel/aigov-615-reverse-proxy-handler-with-recorder-lifecycle-and-key-2
branch
from
September 24, 2026 11:53
7ca2815 to
fdd1bd8
Compare
pawbana
force-pushed
the
pawel/aigov-615-reverse-proxy-handler-with-recorder-lifecycle-and-key-3
branch
from
September 24, 2026 11:53
06bbc31 to
b5d6fb5
Compare
Move the hop-by-hop, transport, and auth header lists next to the proxy and Agent Firewall lists so interception and proxy mode strip the same headers through utils.StripClientRequestHeaders.
Move PrepareClientHeaders to utils so it can be shared between interception and proxy modes.
pawbana
force-pushed
the
pawel/aigov-615-reverse-proxy-handler-with-recorder-lifecycle-and-key-3
branch
2 times, most recently
from
September 24, 2026 15:24
1b68dab to
2073fab
Compare
Restore the original per-group subtests from intercept so the test move is verbatim apart from the package qualifier.
| actorHeaderPrefixLower = "x-ai-bridge-actor" | ||
| ) | ||
|
|
||
| // hopByHopHeaders are connection-level headers specific to the connection |
Collaborator
There was a problem hiding this comment.
I would prefer if we have this in something like aibridge/headers instead of utils. Possibly with the actor headers logic?
pawbana
force-pushed
the
pawel/aigov-615-reverse-proxy-handler-with-recorder-lifecycle-and-key-2
branch
2 times, most recently
from
September 28, 2026 10:39
5f648df to
5810943
Compare
Base automatically changed from
pawel/aigov-615-reverse-proxy-handler-with-recorder-lifecycle-and-key-2
to
main
September 28, 2026 10:55
Collaborator
Author
|
Done in #29718 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
PrepareClientHeadersand its header lists fromintercepttoutilsso the reverse proxy can strip the same client headers as interception. No behavior change.utils.PrepareClientHeaders: unchanged header lists (hop-by-hop, transport, auth, proxy, Agent Firewall). Callers set the upstream credential afterwards.intercept.BuildUpstreamHeaderscalls it and restores the SDK credential and actor headers as before.Generated by Coder Agents on behalf of @pawbana.