Repository navigation
feat(site/src/pages/AISettingsPage/SpendPage): compose the spend page view - #29629
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa1846b785
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fa1846b to
a609b6e
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
a609b6e to
cc8aca9
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
cc8aca9 to
a4d2a0a
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
a4d2a0a to
53cd7ea
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
53cd7ea to
bcef253
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
bcef253 to
6ce4541
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
6ce4541 to
9875093
Compare
9875093 to
c462e13
Compare
15ec00c to
1359bfa
Compare
…rganization picker by its prompt Drop the aria-label that hid the visible "Select an organization" prompt from the trigger's accessible name, render the budget-period placeholder as status text instead of a disabled button, and cover organization selection in both flows with a view test asserting onOrganizationChange.
…he report has no data The date picker was mounted disabled while a fresh or refiltered report was still loading, before the retention bound that limits it had arrived. Show a skeleton in its place until the report resolves, and drop the story that only captured the disabled picker; the Loading story now covers the pending state.
…leton with utility classes
1359bfa to
2899666
Compare
Adds
SpendPageView, the presentational page: paywall and not-enabled states, the organizations loading, error, and empty states, a warning when the requested organization is unavailable, and the filters row (SpendFilters: organization picker hidden with a single organization, optional provider, model, and client menus, and the date range picker or a non-interactive Current budget period label when no explicit range is applied).Why
Keeping the view stateless lets its stories cover every page-level state without network mocks; the container PR above wires the data.
What to scrutinize
SpendFilterspassesMaxAISpendPeriodDaysandminDateto the picker. This layer shows a skeleton while the report is loading; feat(site/src): map the spend reporting period to selectable days within retention #29631 separates the initial retention-bound load from subsequent report loads so the picker stays mounted. The container decides whendateRangeis undefined.SpendPageView.stories.tsxholds only page-level states; table states moved to the table PR below.Validation
pnpm test:storybookonSpendPageView.stories.tsx, repository pre-commit.Delivery record
Published head
c462e135906passed per-layer integration checks and commit hooks. The composed headd899228f798passed format, check, full frontend lint, 125 unit tests, and 86 story tests. Pre-push hooks were skipped as requested. See #28964 for audit findings, their disposition, and historical UAT limits. No exact-head live UAT or new independent re-review is claimed.Stack context
PR 5 of 9. The stack adds a User spend page under Admin settings > AI > User spend: total and per-user AI Gateway spend for one organization over a reporting period, read from
GET /api/v2/organizations/{organization}/ai/spend/users(#29129, merged). It is #28964 split into one-concern PRs. Historical UAT covers earlier heads only; live UAT has not been rerun after these review fixes. Bottom to top: DateRangePicker limits, shared dimension badge, API client method, spend table, page view, page container, reporting period, dimension filters, route and navigation (#28964).