Repository navigation
fix(site/src/pages/AgentsPage): size embedded agent chat to viewport - #29602
Conversation
|
Confirmed this fix against the real production-mode The deployed dogfood embed reproduces the issue. The document grows to the transcript height, no message scroller is created, and the composer extends below the chat pane. The branch embed stays bounded to the pane, moves overflow into the message scroller, and remains fully visible after typing.
Before: deployed dogfood embedAfter: PR branch embedThe screenshots use the real production prototypes page and its exact iframe position and dimensions. The headless browser could not authenticate the cross-origin workspace preview iframe, so I loaded each exact chat embed directly at 398x753, measured it, redacted the live transcript, and placed it at the real iframe coordinates in the full-page capture. Follow-up commit Generated with Coder Agents on behalf of @bpmct |


Embedded agent chats in fixed-height iframes, including the chat panel on
prototypes.cdr.dev, grew to the transcript height and left the composer clipped below the viewport.The embed route rendered directly under block-level
#root, so the chat view'sflex-1andmin-h-0did not constrain it. Add the missing full-height flex column around the route outlet, size the chat view to its parent, and add a 412px-tall Storybook state for visual regression coverage. The embed also waits for permissions before mountingDashboardProvider, preventing dev-proxy loads from crashing while the permissions query is still pending.Screenshots
Live dogfood transcript content is redacted.
Individual screenshots
Before
After
Compiled bundle measurements
Verification
origin/mainand this branch against an authenticated dogfood session on separate ports.EmbeddedViewportStorybook state.pnpm test:storybook src/pages/AgentsPage/AgentChatPageView.stories.tsx: 66 passed.pnpm check,pnpm lint, andpnpm lint:typespassed. Biome reports one existing informational finding inOAuth2AppForm.test.tsx.VITEST_MAX_WORKERS=1: 3656 passed, 2 skipped, and the production site build passed.🤖 Generated with Coder Agents.