Repository navigation
feat!: remove the experimental chat API mounts after the transition window - #29548
Conversation
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Documentation CheckUpdates Needed
Automated review via Coder Agents |
2aa5e41 to
666332f
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 666332f579
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Remove the
/api/experimentalduplicates of the promoted chat API. #28496 double-mounted the chat, organization chat and MCP server, member model-override, AI provider key, and MCP OAuth2 disconnect routes under both prefixes for the one-release compatibility window decided in CODAGT-921; that window closed with v2.37.0, so these routes now answer only on/api/v2. The change also deletes what existed only for the dual mount: thechatAPIPrefixplumbing, the shared cross-prefix files rate limiter (RateLimitByAPICompatibilityEndpoint), the 410 tombstones for the legacychats/providersandchats/user-provider-configscollections with theirExperimentalClientSDK methods, and the/providersand/user-provider-configs404 reservations on/api/v2. Signed chat file download URLs now point at/api/v2.Routes that were never promoted stay on
/api/experimental: the experiment-gatedchats/config/advisorandchats/config/computer-use-provider,chats/{chat}/stream/desktop,chats/{chat}/debug/runs, and the MCP OAuth2 callback, whose path is pinned as a registered redirect URI with external providers. The frontend already calls/api/v2for every promoted route, so onlytypesGenerated.tschanges. Because the experimental mount no longer reserves the removed collection segments, requests such asGET /api/experimental/chats/modelsnow fall into the{chat}wildcard and return 400 instead of 404; the experimental prefix carries no stability guarantee and the compatibility window is over, so no new reservations were added.coderd/x/chatd/ARCHITECTURE.mdnow describes the single/api/v2mount and the remaining experimental routes, and its endpoint headings use the/api/v2paths.Closes CODAGT-922 (https://linear.app/codercom/issue/CODAGT-922/remove-experimental-chats-api-paths-after-transition-window). Refs #28496.
Delivery record
coderd/x/chatd/ARCHITECTURE.mdonly); the current head 666332f carries the same code diff, so the tested branch code is unchanged. Covered the Agents UI end to end on/api/v2(chat, streaming reply, reload mid-stream, file upload and download, debug runs panel), the admin AI settings pages with persisted saves, 45 curl route checks across both prefixes, websocket handshakes, the frozen MCP callback redirect URI, and the files rate limiter. One low-severity note: the 400-versus-404 behavior for removed experimental collection paths described above.@codex review): one P1 thread asking for TODO markers instead of the directARCHITECTURE.mdedit; replied and resolved because the PR author reviewed the earlier TODO markers and directed this replacement text. No unresolved threads. CI is green on 666332f (run 35376339802;test-go-pg-17passed on rerun after a Docker Hub timeout inTestSSH_Container/OK).Note
Xum acted on @ibetitsmike's behalf in this pull request.