Skip to content

feat!: remove the experimental chat API mounts after the transition window - #29548

Merged
ibetitsmike merged 2 commits into
mainfrom
mike/codagt-922-remove-experimental-chat-mounts
Sep 21, 2026
Merged

ibetitsmike merged 2 commits into
mainfrom
mike/codagt-922-remove-experimental-chat-mounts

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented Sep 18, 2026 •

Copy link
Copy Markdown
Collaborator

Remove the /api/experimental duplicates of the promoted chat API. #28496 double-mounted the chat, organization chat and MCP server, member model-override, AI provider key, and MCP OAuth2 disconnect routes under both prefixes for the one-release compatibility window decided in CODAGT-921; that window closed with v2.37.0, so these routes now answer only on /api/v2. The change also deletes what existed only for the dual mount: the chatAPIPrefix plumbing, the shared cross-prefix files rate limiter (RateLimitByAPICompatibilityEndpoint), the 410 tombstones for the legacy chats/providers and chats/user-provider-configs collections with their ExperimentalClient SDK methods, and the /providers and /user-provider-configs 404 reservations on /api/v2. Signed chat file download URLs now point at /api/v2.

Routes that were never promoted stay on /api/experimental: the experiment-gated chats/config/advisor and chats/config/computer-use-provider, chats/{chat}/stream/desktop, chats/{chat}/debug/runs, and the MCP OAuth2 callback, whose path is pinned as a registered redirect URI with external providers. The frontend already calls /api/v2 for every promoted route, so only typesGenerated.ts changes. Because the experimental mount no longer reserves the removed collection segments, requests such as GET /api/experimental/chats/models now fall into the {chat} wildcard and return 400 instead of 404; the experimental prefix carries no stability guarantee and the compatibility window is over, so no new reservations were added.

coderd/x/chatd/ARCHITECTURE.md now describes the single /api/v2 mount and the remaining experimental routes, and its endpoint headings use the /api/v2 paths.

Closes CODAGT-922 (https://linear.app/codercom/issue/CODAGT-922/remove-experimental-chats-api-paths-after-transition-window). Refs #28496.

Delivery record

  • Remote dogfood UAT (Coder Agents chat https://dogfood.cdr.dev/agents/c016b549-201a-4eca-a50f-3c0b7c339db6): verdict PASS on b008976. The branch was since rebased onto main (which had a duplicate migration 000596 until fix(coderd/database): renumber duplicate migration 000596 to 000597 #29568) and gained one docs-only commit (coderd/x/chatd/ARCHITECTURE.md only); the current head 666332f carries the same code diff, so the tested branch code is unchanged. Covered the Agents UI end to end on /api/v2 (chat, streaming reply, reload mid-stream, file upload and download, debug runs panel), the admin AI settings pages with persisted saves, 45 curl route checks across both prefixes, websocket handshakes, the frozen MCP callback redirect URI, and the files rate limiter. One low-severity note: the 400-versus-404 behavior for removed experimental collection paths described above.
  • Codex review on b008976 (draft marked ready): no findings. Codex review on the current head 666332f (requested via @codex review): one P1 thread asking for TODO markers instead of the direct ARCHITECTURE.md edit; replied and resolved because the PR author reviewed the earlier TODO markers and directed this replacement text. No unresolved threads. CI is green on 666332f (run 35376339802; test-go-pg-17 passed on rerun after a Docker Hub timeout in TestSSH_Container/OK).

Note

Xum acted on @ibetitsmike's behalf in this pull request.

@github-actions

Copy link
Copy Markdown
Contributor

Docs preview

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

@github-actions github-actions Bot added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Sep 18, 2026
@linear-code

linear-code Bot commented Sep 18, 2026

Copy link
Copy Markdown

CODAGT-922

@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-18T18:35:00.730935Z 666332f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: b008976a4d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibetitsmike
ibetitsmike marked this pull request as ready for review September 18, 2026 14:34
@coderagents

coderagents Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Documentation Check

Updates Needed

  • docs/ai-coder/agents/platform-controls/advisor.md (open) - Addressed in this PR: the advisor model override path is now PUT /api/v2/organizations/{organization}/chats/model-overrides/advisor, matching the promoted route. The runtime config routes on lines 50-51 (GET/PUT /api/experimental/chats/config/advisor) stay experimental-only, so that part remains correct.

Note: two pre-existing pages document API paths that only ever answered on /api/experimental but are written with /api/v2: docs/ai-coder/agents/platform-controls/chat-debug-logging.md lines 55-93 (/api/v2/chats/{chat}/debug/runs) and docs/ai-coder/agents/platform-controls/virtual-desktop.md lines 45-46 (/api/v2/chats/config/computer-use-provider). This PR does not touch those pages, so it is not listed as an item here; flagging for the maintainers' awareness.


Automated review via Coder Agents

@ibetitsmike
ibetitsmike force-pushed the mike/codagt-922-remove-experimental-chat-mounts branch from 2aa5e41 to 666332f Compare September 18, 2026 17:46
@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 666332f579

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread coderd/x/chatd/ARCHITECTURE.md Resolved
@ibetitsmike
ibetitsmike merged commit 9885204 into main Sep 21, 2026
59 of 61 checks passed
@ibetitsmike
ibetitsmike deleted the mike/codagt-922-remove-experimental-chat-mounts branch September 21, 2026 15:42
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release/breaking This label is applied to PRs to detect breaking changes as part of the release process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants