fix(coderd/agentapi): reject missing RPC messages (#29150) - #29366
Open
dylanhuff-at-coder wants to merge 1 commit into
Open
dylanhuff-at-coder wants to merge 1 commit into
dylanhuff-at-coder wants to merge 1 commit into
Conversation
Reject `UpdateLifecycle`, `UpdateStartup`, and `BatchUpdateMetadata` requests with a missing sub-message using `InvalidArgument` instead of panicking. The whole metadata batch is validated before any value is trimmed or queued. Adds tests for each handler, a mixed metadata batch, and one DRPC round-trip confirming the code propagates and the connection stays usable. Refs PLAT-596 Reviewed and updated by Coder Agents on behalf of @dylanhuff-at-coder. (cherry picked from commit 9c58283)
brittany-coder
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #29150 to
release/2.34.Reject missing lifecycle, startup, and metadata sub-messages with
InvalidArgumentinstead of panicking. Validate the entire metadata batch before modifying or queuing values.Backport context
Cherry-picks
9c58283d8e7a036a45820f76da7f05ffcf81d611without changes. The automatic backport failed while pushing the branch.Generated by Coder Agents on behalf of @dylanhuff-at-coder.