Skip to content

fix(coderd/agentapi): reject missing RPC messages (#29150) - #29358

Open
github-actions[bot] wants to merge 1 commit into
release/2.37from
backport/29150-to-2.37
Open

github-actions[bot] wants to merge 1 commit into
release/2.37from
backport/29150-to-2.37

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Backport of #29150

Original PR: #29150 — fix(coderd/agentapi): reject missing RPC messages
Merge commit: 9c58283
Requested by: @dylanhuff-at-coder

Reject `UpdateLifecycle`, `UpdateStartup`, and `BatchUpdateMetadata`
requests with a missing sub-message using `InvalidArgument` instead of
panicking. The whole metadata batch is validated before any value is
trimmed or queued.

Adds tests for each handler, a mixed metadata batch, and one DRPC
round-trip confirming the code propagates and the connection stays
usable.

Refs PLAT-596

Reviewed and updated by Coder Agents on behalf of @dylanhuff-at-coder.

(cherry picked from commit 9c58283)
@github-actions github-actions Bot added the backport/v2.37 Backport PR targeting release/2.37 label Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/v2.37 Backport PR targeting release/2.37

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants