refactor(aibridge): share request admission and shutdown middleware - #29348
Conversation
This was referenced Sep 15, 2026
pawbana
added this pull request to stack #29350
September 15, 2026 13:02
pawbana
force-pushed
the
pawel/aigov-614-add-ai-gateway-reverse-proxy-experiment-and-stateless-proxy-2
branch
from
September 15, 2026 13:36
7ebb218 to
9b67d8e
Compare
pawbana
force-pushed
the
pawel/aigov-614-add-ai-gateway-reverse-proxy-experiment-and-stateless-proxy-2
branch
from
September 15, 2026 14:41
9b67d8e to
83f2261
Compare
pawbana
force-pushed
the
pawel/aigov-614-add-ai-gateway-reverse-proxy-experiment-and-stateless-proxy-2
branch
from
September 15, 2026 14:57
83f2261 to
7bb3d13
Compare
pawbana
marked this pull request as ready for review
September 15, 2026 15:58
johnstcn
reviewed
Sep 15, 2026
| opt(b) | ||
| } | ||
| b.handler = b.inflight.Middleware(func() { | ||
| _ = b.clock.Now("serve_admission") // Trap point for deterministic race tests. |
Member
There was a problem hiding this comment.
As far as I can tell, this onAdmit function is only ever used for this purpose? If so, should we just inline this behaviour into the inflight middleware?
Contributor
Author
There was a problem hiding this comment.
Good catch. Removed onAdmit.
johnstcn
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InflightGatemiddleware.Generated by Coder Agents on behalf of @pawbana.