Repository navigation
Conversation
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
0c69c28 to
b5b2f14
Compare
16e5201 to
824d636
Compare
b5b2f14 to
53fcc19
Compare
824d636 to
c99d1ef
Compare
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c99d1efeed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
53fcc19 to
4a251f2
Compare
c99d1ef to
5c67ac9
Compare
4a251f2 to
2ec2d16
Compare
5c67ac9 to
57d338d
Compare
2ec2d16 to
8e9e951
Compare
57d338d to
63f9abe
Compare
8e9e951 to
cb5979d
Compare
146d221 to
97427a1
Compare
cb5979d to
8e6a51d
Compare
97427a1 to
02e868b
Compare
8e6a51d to
11b612f
Compare
02e868b to
51ababa
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51ababaa32
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Adds the user-scoped memory table keyed by (user, organization), the chat_user_memory RBAC resource with owner-scoped member permissions, the chat_personal_memory_enabled user config, and renames the extraction cursor table to chat_memory_cursors since it serves both scopes.
Memory tools, index rendering, and post-turn extraction now work against a MemoryStore interface with project and personal adapters. A root chat in a project uses project memory; a root chat without one uses the owner's personal memory for that organization unless they disabled it. Tools are renamed read_memory, save_memory, and delete_memory since the scope is implicit.
…toggle Exposes the caller's personal memories at /api/experimental/chats/memories and the per-user enable flag at /chats/config/user-memory, with SDK methods, audit entries, and cross-replica cache invalidation for the toggle.
…onsolidation Sharing is out of the stack; the consolidation migration returns to 000600.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4dec64beb1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…to f0ssel/chat-memory-consolidation # Conflicts: # coderd/x/chatd/memory_extract.go
…to f0ssel/chat-memory-consolidation
… window and reject overlapping mutations
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92413ebe09
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…to f0ssel/chat-memory-consolidation # Conflicts: # coderd/chat_routes.go
…del was not shown
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b19f1b438a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…d runs at the cap, and record empty applies as skipped
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0f8003bac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…lete memory bodies
…to f0ssel/chat-memory-consolidation
… and overlap name-sorted windows
|
@codex review |
…to f0ssel/chat-memory-consolidation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 945764c9b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…to f0ssel/chat-memory-consolidation
…ick-only model plan
…to f0ssel/chat-memory-consolidation
…to f0ssel/chat-memory-consolidation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a45efbe762
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return | ||
| } | ||
| call := resolved.newObjectCall("memory_consolidation", "Choose memories to delete or merge.", memoryConsolidationMaxOutputTokens) | ||
| call.Prompt = quickgenPrompt(memoryConsolidationPrompt, chattool.FormatMemoryIndexForTool(entries)) |
There was a problem hiding this comment.
Keep untrusted descriptions out of destructive model plans
When a stored memory description contains prompt-injection text, this places it verbatim in the user message that decides which rows to delete or merge. NormalizeMemoryText preserves ordinary instructions and newlines, while planMemoryConsolidation only verifies that returned names exist, so a crafted description can induce the model to name unrelated memories and the Chatd-scoped apply transaction will delete them. Treat descriptions as untrusted data and avoid using an unreviewed model response as authorization for destructive mutations.
Useful? React with 👍 / 👎.
|
Closing: consolidation is replaced by the in-turn contract in #29301 (save_memory warns from 180 memories and, at the cap, tells the agent to delete or fold in the same turn), mirroring how Claude Code handles its MEMORY.md limit. No background cleanup ships in this round. |
FinishTurn, at most once an hour per project (chat_projects.memory_consolidated_at, set before the model call so failures are rate-limited too).{keep, drop}merge groups; it never writes memory text.Generated with Coder Agents on behalf of @f0ssel.