Repository navigation
fix(dogfood/coder): refresh apt keyrings and rename google-cloud-sdk - #29279
Merged
Merged
Conversation
The dogfood base image build has failed on main since 2026-09-11 on both the 22.04 and 26.04 legs. Two independent upstream changes are responsible. HashiCorp now signs apt.releases.hashicorp.com with a new key (FC9CA96ACA026560, created 2026-09-09). The checked-in hashicorp.gpg only held the 2023 key (AA16FCBCA621E701), so apt-get update failed with NO_PUBKEY. Running update-keys.sh in both distro directories picks up the new key. It also refreshes github-cli.gpg and google-cloud.gpg, which had drifted upstream but were not failing. Google has stopped publishing google-cloud-sdk and google-cloud-sdk-datastore-emulator in the cloud-sdk suite; the packages are now google-cloud-cli and google-cloud-cli-datastore-emulator. apt-get install failed with "no installation candidate" once the key problem was fixed. Rename the packages in both Dockerfile.base files and in preferences.d/google-cloud, whose allowlist pins would otherwise leave the new names at priority 1.
ethanndickson
marked this pull request as ready for review
September 14, 2026 07:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
matifali
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dogfood base image has been failing to build on
mainsince the 11th, on both the 22.04 and 26.04 legs: https://github.com/coder/coder/actions/runs/34796906035HashiCorp started signing their apt repo with a new key on the 9th. The
hashicorp.gpgwe ship only has the 2023 key, and as far as I can tell it hasn't been refreshed since it was first added. To fix, we'll just re-runupdate-keys.shin both distro directories. This also picks up newergithub-cli.gpgandgoogle-cloud.gpgkeyrings, neither of which were actually failing.It turns out that was masking a second failure, as
apt-get updatewas aborting theRUNbeforeapt-get installever ran. Google no longer publishesgoogle-cloud-sdk(orgoogle-cloud-sdk-datastore-emulator) in thecloud-sdksuite; they're nowgoogle-cloud-cliandgoogle-cloud-cli-datastore-emulator. So, we'll rename them in bothDockerfile.basefiles, and inpreferences.d/google-cloud, which pins everything from that repo to priority 1 unless allowlisted by name.