fix(coderd/agentapi): reject missing RPC messages - #29150
Merged
dylanhuff-at-coder merged 2 commits intoSep 15, 2026
Merged
dylanhuff-at-coder merged 2 commits into
dylanhuff-at-coder merged 2 commits into
Conversation
dylanhuff-at-coder
marked this pull request as ready for review
September 10, 2026 17:10
dylanhuff-at-coder
requested review from
a team and
snagles
and removed request for
a team and
snagles
September 10, 2026 18:59
dylanhuff-at-coder
deleted the
dylan/plat-596-security-nil-proto-sub-messages-panic-in-three-agent-rpc
branch
September 15, 2026 15:18
dylanhuff-at-coder
added
backport
backport/v2.34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject
UpdateLifecycle,UpdateStartup, andBatchUpdateMetadatarequests with a missing sub-message usingInvalidArgumentinstead of panicking. The whole metadata batch is validated before any value is trimmed or queued.Adds tests for each handler, a mixed metadata batch, and one DRPC round-trip confirming the code propagates and the connection stays usable.
Refs PLAT-596
Reviewed and updated by Coder Agents on behalf of @dylanhuff-at-coder.