Repository navigation
fix(site/src/pages/AgentsPage): keep the prompt composer editable while chats load - #29119
Conversation
…le chats load Keep the prompt composer editable while chat and create-form data is still loading, and only block Send until models, MCP, overrides, and related checks are ready. Archived chats hide the composer entirely once the chat record is known, so a locked prompt box is not left sitting under a read-only transcript. - Typing stays available during load; Enter and Send no-op until the form can actually submit - Archived, other-user, and forbidden chats stay non-editable (archived hides the input) - The loading skeleton can still flash the composer before archive state arrives
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc8e70f82a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| onEnter={handleSubmit} | ||
| sendShortcut={sendShortcut} | ||
| disabled={isDisabled || isLoading} | ||
| disabled={isReadOnly || isLoading} |
There was a problem hiding this comment.
Propagate known read-only state into the loading composer
When chat metadata resolves before message history, AgentChatPage remains on its loading branch because chatMessagesQuery.isLoading is still true, but AgentChatPageLoadingView only forwards isInputDisabled. Since this line no longer uses that flag to control editor editability, a chat already known to be archived or owned by another user remains editable until its messages finish loading; any entered draft is then unexpectedly hidden or locked when the full view appears. Pass the known archived/other-user state through as isReadOnly, and hide the loading composer once an archived record is known.
Useful? React with 👍 / 👎.
DanielleMaywood
left a comment
There was a problem hiding this comment.
Too many storybook crimes
Keep the prompt composer editable while chat and create-form data is still loading, and only block Send until models, MCP, overrides, and related checks are ready. Archived chats hide the composer entirely once the chat record is known, so a locked prompt box is not left sitting under a read-only transcript.