Skip to content

fix(site/src/pages/AgentsPage): keep the prompt composer editable while chats load - #29119

Merged
jakehwll merged 5 commits into
mainfrom
jakehwll/editable-chat-input
Sep 10, 2026
Merged

jakehwll merged 5 commits into
mainfrom
jakehwll/editable-chat-input

Conversation

@jakehwll

@jakehwll jakehwll commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Keep the prompt composer editable while chat and create-form data is still loading, and only block Send until models, MCP, overrides, and related checks are ready. Archived chats hide the composer entirely once the chat record is known, so a locked prompt box is not left sitting under a read-only transcript.

  • Typing stays available during load; Enter and Send no-op until the form can actually submit
  • Archived, other-user, and forbidden chats stay non-editable (archived hides the input)
  • The loading skeleton can still flash the composer before archive state arrives

…le chats load

Keep the prompt composer editable while chat and create-form data is still loading, and only block Send until models, MCP, overrides, and related checks are ready. Archived chats hide the composer entirely once the chat record is known, so a locked prompt box is not left sitting under a read-only transcript.

- Typing stays available during load; Enter and Send no-op until the form can actually submit
- Archived, other-user, and forbidden chats stay non-editable (archived hides the input)
- The loading skeleton can still flash the composer before archive state arrives
@jakehwll
jakehwll marked this pull request as ready for review September 9, 2026 05:21
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-09T05:25:37.652505Z bc8e70f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bc8e70f82a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

onEnter={handleSubmit}
sendShortcut={sendShortcut}
disabled={isDisabled || isLoading}
disabled={isReadOnly || isLoading}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Propagate known read-only state into the loading composer

When chat metadata resolves before message history, AgentChatPage remains on its loading branch because chatMessagesQuery.isLoading is still true, but AgentChatPageLoadingView only forwards isInputDisabled. Since this line no longer uses that flag to control editor editability, a chat already known to be archived or owned by another user remains editable until its messages finish loading; any entered draft is then unexpectedly hidden or locked when the full view appears. Pass the known archived/other-user state through as isReadOnly, and hide the loading composer once an archived record is known.

Useful? React with 👍 / 👎.

@DanielleMaywood DanielleMaywood left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many storybook crimes

@jakehwll
jakehwll enabled auto-merge (squash) September 10, 2026 13:16
@jakehwll
jakehwll merged commit 599b87e into main Sep 10, 2026
25 of 26 checks passed
@jakehwll
jakehwll deleted the jakehwll/editable-chat-input branch September 10, 2026 13:53
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants