Skip to content

refactor(site): drive plan mode from mutation pending state - #29117

Merged
jakehwll merged 9 commits into
mainfrom
jakehwll/agent-chat-plan-mode
Sep 10, 2026
Merged

jakehwll merged 9 commits into
mainfrom
jakehwll/agent-chat-plan-mode

Conversation

@jakehwll

@jakehwll jakehwll commented Sep 9, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 This PR was modified by Coder Agents on behalf of Jake Howell.

use React Query mutation state as the source of truth for pending chat workspace and plan mode updates

  • disables chat-turn actions while chat settings or another submission are pending
  • clears plan mode atomically when sending the Implement Plan message
  • keeps Ask User Question responses open and retryable when submission fails
  • removes the parallel Promise-ref tracking and reconciliation helper

Plan mode and workspace updates were tracked with Promise refs and a third "clear" sentinel so a following send could wait on them. Those are React Query mutations, so send and Implement Plan now key off isPending, and clearing plan mode on Implement Plan goes through toChatPlanModePayload.
@jakehwll
jakehwll requested a review from ibetitsmike September 9, 2026 03:58
@jakehwll
jakehwll marked this pull request as ready for review September 9, 2026 03:59
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-09T04:05:16.474898Z f7d9198 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7d9198115

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread site/src/api/queries/chats.ts Resolved
@jakehwll
jakehwll merged commit 712c763 into main Sep 10, 2026
26 checks passed
@jakehwll
jakehwll deleted the jakehwll/agent-chat-plan-mode branch September 10, 2026 13:11
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants