Skip to content

refactor(site/src/pages/AgentsPage): move chat sharing into ChatTopBar - #29116

Merged
jakehwll merged 3 commits into
mainfrom
jakehwll/share-from-chattopbar
Sep 9, 2026
Merged

jakehwll merged 3 commits into
mainfrom
jakehwll/share-from-chattopbar

Conversation

@jakehwll

@jakehwll jakehwll commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

ChatTopBar now checks share permission and renders the sharing popover itself, instead of receiving a canShareChat flag and renderChatSharingContent from AgentChatPage.

  • Drop canShareChat from AgentChatPageView
  • Drop the renderChatSharingContent render prop
  • Cover the share button from ChatTopBar stories

ChatTopBar now checks share permission and renders the sharing popover itself, instead of receiving a canShareChat flag and renderChatSharingContent from AgentChatPage.

- Drop canShareChat from AgentChatPageView
- Drop the renderChatSharingContent render prop
- Cover the share button from ChatTopBar stories
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-09T02:08:23.636658Z a3f6ad4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jakehwll
jakehwll enabled auto-merge (squash) September 9, 2026 15:05
@jakehwll
jakehwll merged commit afabc3c into main Sep 9, 2026
26 checks passed
@jakehwll
jakehwll deleted the jakehwll/share-from-chattopbar branch September 9, 2026 15:06
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants