Repository navigation
fix(site): apply design feedback to the workspace filter combobox - #29111
Merged
Merged
Conversation
Design review fixes for the unified workspace search and filter: - Show a dotted filter icon on the toggle while any chip is applied. - Render chips as a muted `key:` prefix with a prominent value. - Present Attributes chips as `attribute:<key>` and rename the category key to `attribute` (with `attributes` as an alias) so chips, the draft prefix, and typed prefixes all use the same pattern. - Dropdown rows: 34px tall, 8px horizontal padding, 24px icon slot with 18px lucide icons and 24px avatars, 13px regular text, group headers with 16px above (8px list padding only for the first header). - Use `BuildingIcon` for Organization and `TagIcon` for Attributes. - Result rows inherit the row colour so text and icons highlight together; drop the workspace result subtitle. - Size the chip-row input to its content so an empty input never forces a second row, and match its height to a chip so the box does not change height when the first chip is added. - Prefix the pagination summary with "Filtered:" while a query is set and use "No workspaces match your search." for empty filtered results, with a "Clear all" button in the empty state.
Owner, Status, Attributes, Template, Organization.
Keep Building2Icon for Organization to match the rest of the app, and render the dotted active filter icon at 20px so it reads the same size as the plain 18px icon.
…er/coder into fix/filter-combobox-feedback
Each category row in the filter dropdown now ends with either the labels of its applied chips plus a check mark, or a short sample of its options (templates and organizations are pulled from the deployment). Categories can provide a hint shown while options load.
Clicking the filter toggle, or pressing Backspace on an empty input, while a category is open returns to the category list instead of closing the menu.
Collaborator
jakehwll
reviewed
Sep 11, 2026
Collaborator
There was a problem hiding this comment.
I do wonder, can we lean harder into the Lucide types here?
jakehwll
approved these changes
Sep 18, 2026
jakehwll
left a comment
Collaborator
There was a problem hiding this comment.
Still not convinced the excluded would work but keen to see in a later part of this stack 🙂
…eedback # Conflicts: # site/src/pages/WorkspacesPage/filter/WorkspacesFilter.stories.tsx # site/src/pages/WorkspacesPage/filter/WorkspacesFilter.tsx
tracyjohnsonux
marked this pull request as ready for review
September 24, 2026 22:41
tracyjohnsonux
enabled auto-merge (squash)
September 24, 2026 22:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Design review follow-ups for the unified workspace search and filter (
FilterCombobox) on/workspaces, continuing #29080.Search box
ListFilterActiveIconwhile at least one chip is applied; it renders 2px larger than the plain icon so both read as the same size.key:prefix in content-secondary and the value in content-primary, at 14px with 8px left padding.attribute:outdated(etc.) instead ofoutdated:true; the category key is nowattributewithattributeskept as a typed alias. The emitted query is unchanged.field-sizing: content) and matches chip height, so an empty input no longer forces a second row and the box no longer changes height when the first chip is added.Dropdown
me). Applied values are content-secondary, the sample is muted; both 12px.TagIcon; Organization keepsBuilding2Icon.SearchResult.subtitlefield) is removed.Table
Filtered:while a query is set; with zero filtered results it readsNo workspaces match your search.Clear allbutton that resets the query.Stories cover the new states (active icon, wrapped chips, attribute chips, category previews and applied values, filtered summary, empty state, Clear all).
chipDisplayandcategoryPreviewhave unit tests.Decision log
currentColorand stroke 2 so it matchesListFilterIconin weight and theming; its shortened top line carries less visual mass, hence the 20px render.text-smwithleading-4so they stay 28px tall and the box height and first-row icon alignment are unchanged.chip(token)matcher on the chip element's full text instead ofgetByText("owner:me").field-sizinginput relies on browser support that is now in Chrome, Safari, and Firefox 152;size={1}keeps the fallback intrinsic width small elsewhere.filterComboboxOptions(key, getOptions, "")), so entering a category hits the react-query cache.FilterCategory.hintis a fixed override of the sample;FilterOption.appliedLabelletsowner:meread asmerather thanadmin (you).text-content-disabledbecause the theme defines nocontent-tertiarytoken (the 18 existingtext-content-tertiaryusages underAgentsPagegenerate no CSS).admindoes not match owneradmin. Left unchanged here; a backend change would be a separate PR.This PR was generated by Coder Agents on behalf of @tracyjohnsonux.