Skip to content

fix(site): polish the workspace filter combobox - #29080

Merged
jakehwll merged 11 commits into
mainfrom
jakehwll/unified-search-feedback
Sep 8, 2026
Merged

jakehwll merged 11 commits into
mainfrom
jakehwll/unified-search-feedback

Conversation

@jakehwll

@jakehwll jakehwll commented Sep 8, 2026 •

Copy link
Copy Markdown
Collaborator

A pile of visual nits from design review on the unified workspace filter. Nothing functional, just making the thing look like the Figma mock.

  • dropdown rows stay content-secondary until hover/highlight, then icon and label go primary together
  • only the suggestion list scrolls, so we don't get two scrollbars
  • search and filter icons stick to the first chip row when tokens wrap
  • chip area padding is 8px top/right/bottom, 4px between tokens
  • bigger dismiss X on chips (why is this a prop?????)
  • Template icon uses LayoutPanelTopIcon, Attributes icon uses TagsIcon
Old New
COMBOBOX_INPUT_OLD COMBOBOX_INPUT_NEW
COMBOBOX_DROPDOWN_OLD COMBOBOX_DROPDOWN_NEW

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-08T09:55:49.859064Z c55e907 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c55e907e48

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jakehwll
jakehwll enabled auto-merge (squash) September 8, 2026 10:04
@jakehwll
jakehwll merged commit 0cda3f0 into main Sep 8, 2026
26 checks passed
@jakehwll
jakehwll deleted the jakehwll/unified-search-feedback branch September 8, 2026 10:14
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants