Repository navigation
refactor(site/src/pages/AgentsPage): read parent chat from ChatTopBar - #29074
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
DanielleMaywood
approved these changes
Sep 8, 2026
ChatTopBar now loads the parent chat itself instead of taking parentChat from AgentChatPage and the view. The page no longer queries chatById for the parent. Depends on #29071 - Drop parentChat from AgentChatPage and AgentChatPageView - ChatTopBar reads chatById when chat has a parent id - WithParentChat seeds the parent entity and asserts the crumb link
jakehwll
force-pushed
the
jakehwll/7-parentid-only-chattopbar
branch
from
September 8, 2026 14:49
749eac0 to
52e6724
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChatTopBar now loads the parent chat itself instead of taking
parentChatfrom AgentChatPage and the view. The page no longer querieschatByIdfor the parent.parentChatfrom AgentChatPage and AgentChatPageViewchatByIdwhen the chat has a parent ID