Skip to content

refactor(site/src/pages/AgentsPage): derive workspace skills in ChatPageInput - #29071

Merged
jakehwll merged 1 commit into
mainfrom
jakehwll/6-derive-workspace-skills
Sep 8, 2026
Merged

jakehwll merged 1 commit into
mainfrom
jakehwll/6-derive-workspace-skills

Conversation

@jakehwll

@jakehwll jakehwll commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

ChatPageInput now derives workspace skills from chat instead of taking a sliced list from AgentChatPage and the view. The page still computes that list for slash-command send.

Depends on #29070

  • Drop workspaceSkills from AgentChatPage and AgentChatPageView
  • ChatPageInput calls workspaceSkillsFromChat(chat)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-08T05:31:03.776837Z f9a6276 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Base automatically changed from jakehwll/5-compaction-thresholds-prop to main September 8, 2026 12:28
…ageInput

ChatPageInput now derives workspace skills from chat instead of taking a sliced list from AgentChatPage and the view. The page still computes that list for slash-command send.

Depends on #29070

- Drop workspaceSkills from AgentChatPage and AgentChatPageView
- ChatPageInput calls workspaceSkillsFromChat(chat)
@jakehwll
jakehwll force-pushed the jakehwll/6-derive-workspace-skills branch from f9a6276 to ec3fe70 Compare September 8, 2026 12:30
@jakehwll
jakehwll merged commit 5bc6553 into main Sep 8, 2026
26 checks passed
@jakehwll
jakehwll deleted the jakehwll/6-derive-workspace-skills branch September 8, 2026 14:38
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants