Skip to content

refactor: read compaction threshold from ChatPageInput - #29070

Merged
jakehwll merged 6 commits into
mainfrom
jakehwll/5-compaction-thresholds-prop
Sep 8, 2026
Merged

jakehwll merged 6 commits into
mainfrom
jakehwll/5-compaction-thresholds-prop

Conversation

@jakehwll

@jakehwll jakehwll commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

ChatPageInput now loads compaction thresholds itself instead of taking compressionThreshold from AgentChatPage and the view. It resolves chat.last_model_config_id against the shared chatModels cache and userCompactionThresholds, the same query settings already uses.

Depends on #29069

  • Drop compressionThreshold from AgentChatPage and AgentChatPageView
  • ChatPageInput reads userCompactionThresholds through resolveCompactionThreshold
  • CompactsAtUserOverride opens the context ring and asserts the user override wins over the model default

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-08T05:23:53.011990Z 68ca3b4 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jakehwll
jakehwll marked this pull request as draft September 8, 2026 05:15
@jakehwll
jakehwll marked this pull request as ready for review September 8, 2026 05:18
@jakehwll
jakehwll requested a review from jaaydenh September 8, 2026 05:18

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 68ca3b440b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jakehwll jakehwll changed the title refactor(site/src/pages/AgentsPage): read compaction threshold from ChatPageInput refactor: read compaction threshold from ChatPageInput Sep 8, 2026

@DanielleMaywood DanielleMaywood left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Pixel is failing

@jakehwll
jakehwll force-pushed the jakehwll/5-compaction-thresholds-prop branch from 5daa9ee to f558d4c Compare September 8, 2026 11:27
Base automatically changed from jakehwll/4-shortcut-prop to main September 8, 2026 11:32
…hatPageInput

ChatPageInput now loads compaction thresholds itself instead of taking compressionThreshold from AgentChatPage and the view. It resolves chat.last_model_config_id against the shared chatModels cache and userCompactionThresholds, the same query settings already uses.

Depends on #29069

- Drop compressionThreshold from AgentChatPage and AgentChatPageView
- ChatPageInput reads userCompactionThresholds through resolveCompactionThreshold
- CompactsAtUserOverride opens the context ring and asserts the user override wins over the model default
@jakehwll
jakehwll force-pushed the jakehwll/5-compaction-thresholds-prop branch from f558d4c to d328092 Compare September 8, 2026 11:32
@jakehwll
jakehwll merged commit 69f40fc into main Sep 8, 2026
26 checks passed
@jakehwll
jakehwll deleted the jakehwll/5-compaction-thresholds-prop branch September 8, 2026 12:28
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants