Repository navigation
refactor: read compaction threshold from ChatPageInput - #29070
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68ca3b440b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
DanielleMaywood
left a comment
There was a problem hiding this comment.
Looks like Pixel is failing
5daa9ee to
f558d4c
Compare
…hatPageInput ChatPageInput now loads compaction thresholds itself instead of taking compressionThreshold from AgentChatPage and the view. It resolves chat.last_model_config_id against the shared chatModels cache and userCompactionThresholds, the same query settings already uses. Depends on #29069 - Drop compressionThreshold from AgentChatPage and AgentChatPageView - ChatPageInput reads userCompactionThresholds through resolveCompactionThreshold - CompactsAtUserOverride opens the context ring and asserts the user override wins over the model default
f558d4c to
d328092
Compare
ChatPageInput now loads compaction thresholds itself instead of taking compressionThreshold from AgentChatPage and the view. It resolves chat.last_model_config_id against the shared chatModels cache and userCompactionThresholds, the same query settings already uses.
Depends on #29069