Skip to content

refactor: read send shortcut from AgentChatInput - #29069

Merged
jakehwll merged 2 commits into
mainfrom
jakehwll/4-shortcut-prop
Sep 8, 2026
Merged

jakehwll merged 2 commits into
mainfrom
jakehwll/4-shortcut-prop

Conversation

@jakehwll

@jakehwll jakehwll commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

AgentChatInput now loads the send shortcut preference itself instead of taking it from AgentChatPage, AgentCreatePage, the view, ChatPageContent, and AgentCreateForm. Loading still uses modifier_enter so Enter cannot send a draft before the stored preference lands.

Depends on #29067

  • Drop sendShortcut from AgentChatPage, AgentCreatePage, AgentChatPageView, ChatPageContent, and AgentCreateForm
  • AgentChatInput reads preferenceSettings through getAgentChatSendShortcut
  • Stories seed MockUserPreferenceSettings on the preference query

@jakehwll
jakehwll marked this pull request as ready for review September 8, 2026 04:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-08T04:59:10.017025Z 03232fc Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jakehwll jakehwll changed the title refactor(site/src/pages/AgentsPage): read send shortcut from AgentChatInput refactor: read send shortcut from AgentChatInput Sep 8, 2026
},
}),
{
key: preferenceSettings().queryKey,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why we do this instead of exporting the query key

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh... interesting agent choice.

yep will fix.

Base automatically changed from jakehwll/3-agentId-predicate to main September 8, 2026 09:23
@jakehwll
jakehwll force-pushed the jakehwll/4-shortcut-prop branch from 79dbae7 to e996de7 Compare September 8, 2026 10:10
…tInput

AgentChatInput now loads the send shortcut preference itself instead of taking it from AgentChatPage, AgentCreatePage, the view, ChatPageContent, and AgentCreateForm. Loading still uses modifier_enter so Enter cannot send a draft before the stored preference lands.

Depends on #29067

- Drop sendShortcut from AgentChatPage, AgentCreatePage, AgentChatPageView, ChatPageContent, and AgentCreateForm
- AgentChatInput reads preferenceSettings through getAgentChatSendShortcut
- Stories seed MockUserPreferenceSettings on the preference query
@jakehwll
jakehwll force-pushed the jakehwll/4-shortcut-prop branch from e996de7 to b007e68 Compare September 8, 2026 11:24
jakehwll added a commit that referenced this pull request Sep 8, 2026
…hatPageInput

ChatPageInput now loads compaction thresholds itself instead of taking compressionThreshold from AgentChatPage and the view. It resolves chat.last_model_config_id against the shared chatModels cache and userCompactionThresholds, the same query settings already uses.

Depends on #29069

- Drop compressionThreshold from AgentChatPage and AgentChatPageView
- ChatPageInput reads userCompactionThresholds through resolveCompactionThreshold
- CompactsAtUserOverride opens the context ring and asserts the user override wins over the model default
@jakehwll
jakehwll merged commit 8e0fcdf into main Sep 8, 2026
26 checks passed
@jakehwll
jakehwll deleted the jakehwll/4-shortcut-prop branch September 8, 2026 11:32
jakehwll added a commit that referenced this pull request Sep 8, 2026
…hatPageInput

ChatPageInput now loads compaction thresholds itself instead of taking compressionThreshold from AgentChatPage and the view. It resolves chat.last_model_config_id against the shared chatModels cache and userCompactionThresholds, the same query settings already uses.

Depends on #29069

- Drop compressionThreshold from AgentChatPage and AgentChatPageView
- ChatPageInput reads userCompactionThresholds through resolveCompactionThreshold
- CompactsAtUserOverride opens the context ring and asserts the user override wins over the model default
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants