Repository navigation
refactor: read send shortcut from AgentChatInput - #29069
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
DanielleMaywood
approved these changes
Sep 8, 2026
| }, | ||
| }), | ||
| { | ||
| key: preferenceSettings().queryKey, |
Collaborator
There was a problem hiding this comment.
Curious why we do this instead of exporting the query key
Collaborator
Author
There was a problem hiding this comment.
huh... interesting agent choice.
yep will fix.
jakehwll
force-pushed
the
jakehwll/4-shortcut-prop
branch
from
September 8, 2026 10:10
79dbae7 to
e996de7
Compare
…tInput AgentChatInput now loads the send shortcut preference itself instead of taking it from AgentChatPage, AgentCreatePage, the view, ChatPageContent, and AgentCreateForm. Loading still uses modifier_enter so Enter cannot send a draft before the stored preference lands. Depends on #29067 - Drop sendShortcut from AgentChatPage, AgentCreatePage, AgentChatPageView, ChatPageContent, and AgentCreateForm - AgentChatInput reads preferenceSettings through getAgentChatSendShortcut - Stories seed MockUserPreferenceSettings on the preference query
jakehwll
force-pushed
the
jakehwll/4-shortcut-prop
branch
from
September 8, 2026 11:24
e996de7 to
b007e68
Compare
jakehwll
added a commit
that referenced
this pull request
Sep 8, 2026
…hatPageInput ChatPageInput now loads compaction thresholds itself instead of taking compressionThreshold from AgentChatPage and the view. It resolves chat.last_model_config_id against the shared chatModels cache and userCompactionThresholds, the same query settings already uses. Depends on #29069 - Drop compressionThreshold from AgentChatPage and AgentChatPageView - ChatPageInput reads userCompactionThresholds through resolveCompactionThreshold - CompactsAtUserOverride opens the context ring and asserts the user override wins over the model default
jakehwll
added a commit
that referenced
this pull request
Sep 8, 2026
…hatPageInput ChatPageInput now loads compaction thresholds itself instead of taking compressionThreshold from AgentChatPage and the view. It resolves chat.last_model_config_id against the shared chatModels cache and userCompactionThresholds, the same query settings already uses. Depends on #29069 - Drop compressionThreshold from AgentChatPage and AgentChatPageView - ChatPageInput reads userCompactionThresholds through resolveCompactionThreshold - CompactsAtUserOverride opens the context ring and asserts the user override wins over the model default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentChatInput now loads the send shortcut preference itself instead of taking it from AgentChatPage, AgentCreatePage, the view, ChatPageContent, and AgentCreateForm. Loading still uses modifier_enter so Enter cannot send a draft before the stored preference lands.
Depends on #29067