Skip to content

refactor(site/src/pages/AgentsPage): treat route agentId as required - #29067

Merged
jakehwll merged 1 commit into
mainfrom
jakehwll/3-agentId-predicate
Sep 8, 2026
Merged

jakehwll merged 1 commit into
mainfrom
jakehwll/3-agentId-predicate

Conversation

@jakehwll

@jakehwll jakehwll commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

AgentChatPage now treats the :agentId route param as required, matching WorkspacePage, instead of coercing a missing id to "". Queries and mutations take that string directly.

Depends on #29065

  • KeyedAgentChatPage renders not-found when the param is missing
  • Drop agentId ?? "" and enabled: Boolean(agentId) from chat queries
  • Drop !agentId guards from send, interrupt, workspace, and plan-mode handlers

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d4154e0bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-08T04:30:07.968669Z 3d4154e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jakehwll
jakehwll force-pushed the jakehwll/3-agentId-predicate branch from 3d4154e to 179abe6 Compare September 8, 2026 08:42
Base automatically changed from jakehwll/2-chat-topbar-outlet-actions to main September 8, 2026 08:56
AgentChatPage now treats the :agentId route param as required, matching WorkspacePage, instead of coercing a missing id to "". Queries and mutations take that string directly.

Depends on #29065

- KeyedAgentChatPage renders not-found when the param is missing
- Drop agentId ?? "" and enabled: Boolean(agentId) from chat queries
- Drop !agentId guards from send, interrupt, workspace, and plan-mode handlers
@jakehwll
jakehwll force-pushed the jakehwll/3-agentId-predicate branch from 179abe6 to 5d86df8 Compare September 8, 2026 08:56
@jakehwll
jakehwll merged commit ab5c059 into main Sep 8, 2026
26 checks passed
@jakehwll
jakehwll deleted the jakehwll/3-agentId-predicate branch September 8, 2026 09:23
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants