Skip to content

refactor(site/src/pages/AgentsPage): read archive pin rename from layout outlet - #29065

Merged
jakehwll merged 7 commits into
mainfrom
jakehwll/2-chat-topbar-outlet-actions
Sep 8, 2026
Merged

jakehwll merged 7 commits into
mainfrom
jakehwll/2-chat-topbar-outlet-actions

Conversation

@jakehwll

@jakehwll jakehwll commented Sep 8, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 This PR was modified by Coder Agents on behalf of Jake Howell.

ChatTopBar now calls the layout outlet archive, pin, and rename actions instead of taking page wrappers drilled through the view. Loading, error, and not-found omit chat, so they no longer need dummy handlers.

Depends on #29064

  • Drop archive, pin, and rename handlers from AgentChatPage and AgentChatPageView
  • Gate archive actions using the per-chat live status and outlet activeChatChildren
  • Exercise every moved outlet action through Storybook interactions

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-08T03:25:09.385016Z aeca994 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aeca9941f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Base automatically changed from jakehwll/1-chat-prop-drilling to main September 8, 2026 07:02

@DanielleMaywood DanielleMaywood left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong but shouldn't defaultChat in the tests be mockChat?

Comment on lines 54 to 56
export const chatHasMenuActions = (chat: TypesGen.Chat): boolean =>
!(chat.archived && getParentChatID(chat) !== undefined);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're accidentally reverting this change?

jakehwll added a commit that referenced this pull request Sep 8, 2026
AgentChatPage now treats the :agentId route param as required, matching WorkspacePage, instead of coercing a missing id to "". Queries and mutations take that string directly.

Depends on #29065

- KeyedAgentChatPage renders not-found when the param is missing
- Drop agentId ?? "" and enabled: Boolean(agentId) from chat queries
- Drop !agentId guards from send, interrupt, workspace, and plan-mode handlers
@jakehwll
jakehwll merged commit 029b0ee into main Sep 8, 2026
25 of 26 checks passed
@jakehwll
jakehwll deleted the jakehwll/2-chat-topbar-outlet-actions branch September 8, 2026 08:56
jakehwll added a commit that referenced this pull request Sep 8, 2026
AgentChatPage now treats the :agentId route param as required, matching WorkspacePage, instead of coercing a missing id to "". Queries and mutations take that string directly.

Depends on #29065

- KeyedAgentChatPage renders not-found when the param is missing
- Drop agentId ?? "" and enabled: Boolean(agentId) from chat queries
- Drop !agentId guards from send, interrupt, workspace, and plan-mode handlers
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants