Repository navigation
refactor(site/src/pages/AgentsPage): read archive pin rename from layout outlet - #29065
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aeca9941f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
DanielleMaywood
left a comment
There was a problem hiding this comment.
Correct me if I'm wrong but shouldn't defaultChat in the tests be mockChat?
| export const chatHasMenuActions = (chat: TypesGen.Chat): boolean => | ||
| !(chat.archived && getParentChatID(chat) !== undefined); | ||
|
|
There was a problem hiding this comment.
I think we're accidentally reverting this change?
AgentChatPage now treats the :agentId route param as required, matching WorkspacePage, instead of coercing a missing id to "". Queries and mutations take that string directly. Depends on #29065 - KeyedAgentChatPage renders not-found when the param is missing - Drop agentId ?? "" and enabled: Boolean(agentId) from chat queries - Drop !agentId guards from send, interrupt, workspace, and plan-mode handlers
AgentChatPage now treats the :agentId route param as required, matching WorkspacePage, instead of coercing a missing id to "". Queries and mutations take that string directly. Depends on #29065 - KeyedAgentChatPage renders not-found when the param is missing - Drop agentId ?? "" and enabled: Boolean(agentId) from chat queries - Drop !agentId guards from send, interrupt, workspace, and plan-mode handlers
ChatTopBar now calls the layout outlet archive, pin, and rename actions instead of taking page wrappers drilled through the view. Loading, error, and not-found omit chat, so they no longer need dummy handlers.
Depends on #29064