Skip to content

refactor(site/src/pages/AgentsPage): pass Chat instead of sliced chat flags - #29064

Merged
jakehwll merged 3 commits into
mainfrom
jakehwll/1-chat-prop-drilling
Sep 8, 2026
Merged

jakehwll merged 3 commits into
mainfrom
jakehwll/1-chat-prop-drilling

Conversation

@jakehwll

@jakehwll jakehwll commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Pass the chat record into ChatTopBar, ChatPageInput, and ChatActionsMenuItems instead of deriving title, pin, archive, child, share, diff, plan mode, workspace, context, and ids at each parent. Handlers stay props. Loading, error, not-found, and the create composer still omit chat because they have no record yet.

  • ChatTopBar reads title, share, pin, archive, parent, and diff from chat
  • ChatPageInput reads org, id, plan mode, workspace, and context from chat
  • ChatActionsMenuItems reads archive/pin/child from chat, so the sidebar tree drops isChildNode

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-08T03:03:02.453691Z f009a7a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jakehwll
jakehwll merged commit 80bb560 into main Sep 8, 2026
26 checks passed
@jakehwll
jakehwll deleted the jakehwll/1-chat-prop-drilling branch September 8, 2026 07:02
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants