Repository navigation
refactor(site/src/pages/AgentsPage): pass Chat into AgentChatPageView - #29035
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
DanielleMaywood
approved these changes
Sep 7, 2026
Comment on lines
+364
to
+366
| const agentId = chat.id; | ||
| const organizationId = chat.organization_id; | ||
| const isArchived = chat.archived; |
Collaborator
There was a problem hiding this comment.
Do we need to pull these out? Also agentId is such an overloaded term on the frontend now 😭😭
Collaborator
Author
There was a problem hiding this comment.
Im going to nuke later. Don't stress 😅 Just cleaning up prop-soup first.
jakehwll
force-pushed
the
jakehwll/5-chat-prop-passing
branch
from
September 7, 2026 10:51
5d4a5c7 to
ae43aa5
Compare
jakehwll
force-pushed
the
jakehwll/5-chat-prop-passing
branch
from
September 7, 2026 10:58
ae43aa5 to
63e72af
Compare
jakehwll
force-pushed
the
jakehwll/5-chat-prop-passing
branch
from
September 7, 2026 11:08
63e72af to
4e5bdb9
Compare
Pass the chat entity into AgentChatPageView instead of slicing it into page props. The view reads archive, share, pin, parent, org, workspace, diff, and related fields from that record. Behavior is unchanged.
jakehwll
force-pushed
the
jakehwll/5-chat-prop-passing
branch
from
September 7, 2026 11:16
4e5bdb9 to
3f8781f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the chat entity into AgentChatPageView instead of slicing it into page props. The view reads archive, share, pin, parent, org, workspace, diff, and related fields from that record. Behavior is unchanged.