Skip to content

refactor(site/src/pages/AgentsPage): pass Chat into AgentChatPageView - #29035

Merged
jakehwll merged 1 commit into
mainfrom
jakehwll/5-chat-prop-passing
Sep 7, 2026
Merged

jakehwll merged 1 commit into
mainfrom
jakehwll/5-chat-prop-passing

Conversation

@jakehwll

@jakehwll jakehwll commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Pass the chat entity into AgentChatPageView instead of slicing it into page props. The view reads archive, share, pin, parent, org, workspace, diff, and related fields from that record. Behavior is unchanged.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-07T10:28:44.286253Z 5d4a5c7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment on lines +364 to +366
const agentId = chat.id;
const organizationId = chat.organization_id;
const isArchived = chat.archived;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to pull these out? Also agentId is such an overloaded term on the frontend now 😭😭

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im going to nuke later. Don't stress 😅 Just cleaning up prop-soup first.

@jakehwll
jakehwll force-pushed the jakehwll/5-chat-prop-passing branch from 5d4a5c7 to ae43aa5 Compare September 7, 2026 10:51
@jakehwll
jakehwll force-pushed the jakehwll/5-chat-prop-passing branch from ae43aa5 to 63e72af Compare September 7, 2026 10:58
@jakehwll
jakehwll force-pushed the jakehwll/5-chat-prop-passing branch from 63e72af to 4e5bdb9 Compare September 7, 2026 11:08
Base automatically changed from jakehwll/4-sidebar-state to main September 7, 2026 11:16
Pass the chat entity into AgentChatPageView instead of slicing it into page props. The view reads archive, share, pin, parent, org, workspace, diff, and related fields from that record. Behavior is unchanged.
@jakehwll
jakehwll force-pushed the jakehwll/5-chat-prop-passing branch from 4e5bdb9 to 3f8781f Compare September 7, 2026 11:16
@jakehwll
jakehwll merged commit d9bafeb into main Sep 7, 2026
26 checks passed
@jakehwll
jakehwll deleted the jakehwll/5-chat-prop-passing branch September 7, 2026 11:26
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants