Skip to content

refactor(site/src/pages/AgentsPage): extract AgentChatPage helpers and hooks - #29032

Merged
jakehwll merged 4 commits into
mainfrom
jakehwll/3-refactor-variables
Sep 7, 2026
Merged

jakehwll merged 4 commits into
mainfrom
jakehwll/3-refactor-variables

Conversation

@jakehwll

@jakehwll jakehwll commented Sep 7, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 Refactoring with Cursor.

Pull already-tested helpers and the conversation-editing, workspace-watch, and right-panel preference logic out of AgentChatPage into colocated modules. The document title now lives on the page instead of being passed through views.

Behavior is unchanged. The send pipeline and AgentChatPageView stay put.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-07T09:34:58.795618Z bfe38c1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@DanielleMaywood DanielleMaywood left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced I like the Page/PageView split we have. So many props getting drilled. Maybe it's fine though

@jakehwll
jakehwll force-pushed the jakehwll/3-refactor-variables branch from bfe38c1 to 1cd5fff Compare September 7, 2026 10:51
Base automatically changed from jakehwll/2-agents-extract-hooks to main September 7, 2026 10:58
@jakehwll
jakehwll force-pushed the jakehwll/3-refactor-variables branch from 1cd5fff to 60c0749 Compare September 7, 2026 10:58
@jakehwll
jakehwll merged commit 2cabde1 into main Sep 7, 2026
22 checks passed
@jakehwll
jakehwll deleted the jakehwll/3-refactor-variables branch September 7, 2026 11:08
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants