Skip to content

refactor(site/src): migrate click info popovers to hover tooltips - #28875

Merged
chrifro merged 1 commit into
mainfrom
chrifro/hover-info-tooltips
Sep 18, 2026
Merged

chrifro merged 1 commit into
mainfrom
chrifro/hover-info-tooltips

Conversation

@chrifro

@chrifro chrifro commented Sep 1, 2026 •

Copy link
Copy Markdown
Collaborator

Part 2 of 2 of the tooltip cleanup (split for review). Stacked on #28903 — review/merge that first.

Migrates the click-based HelpPopover info affordances across pages and modules to the hover InfoTooltip (and the base Tooltip for the agent status/latency indicators) added in #28903, so help text reveals on hover consistently.

Converted: Audit, Connection log, AI Gateway, Workspaces, Templates, Template embed, Publish version, IdP group/org sync, Create workspace, Workspace parameters, Template insights, User roles/groups, Active users, and the agent status/latency/warning indicators. Also removes the leftover cursor-help "?" cursor from tooltip triggers.

Genuinely interactive popovers stay click based (a hover tooltip is the wrong primitive): the workspace/agent "outdated → Update" popovers, the SSH / port-forward / build-parameter menus, and the breadcrumb hovercards.

Before / After

Representative example (the same shared component every migrated call site now uses). Help reveals on hover (was click), uses the info / warning icon (was a ?), opens to the right, and links match the body text size.

Before — click popover After — hover tooltip
Info
Warning
Design decisions
  • Two families exist and were easy to confuse: hover Tooltip (transient labels) and click HelpPopover (rich content). This work moves every genuine info/help reveal onto the hover family and keeps interactive surfaces on the click family.
  • Icon size is preserved per call site via the size prop (small = 12px, medium = 16px) to match the previous HelpPopoverIconTrigger sizes.
  • Links inside tooltips use Link size="sm" so they match the text-xs body, with a small top margin for separation.
  • Left as click popovers: AgentOutdatedTooltip, SubAgentOutdatedTooltip, WorkspaceOutdatedTooltip (contain an Update action with controlled open state), SSHButton / PortForwardButton / BuildParametersPopover (button-triggered menus/forms), and the WorkspaceTopbar breadcrumb hovercards (navigation links).

Stack


🤖 Generated with Coder Agents on behalf of @chrifro.

@chrifro
chrifro force-pushed the chrifro/hover-info-tooltips branch 2 times, most recently from dea8e98 to 7a1054d Compare September 2, 2026 12:00
@chrifro chrifro changed the title refactor(site/src): standardize info affordances on hover tooltips refactor(site/src): migrate click info popovers to hover tooltips Sep 2, 2026
@chrifro
chrifro changed the base branch from main to chrifro/hover-tooltips-foundation September 2, 2026 12:01
@chrifro
chrifro force-pushed the chrifro/hover-info-tooltips branch from 7a1054d to 8685f10 Compare September 2, 2026 12:34
@chrifro
chrifro marked this pull request as ready for review September 2, 2026 12:49
@chrifro
chrifro force-pushed the chrifro/hover-info-tooltips branch from 8685f10 to 98979c5 Compare September 11, 2026 13:29
@chrifro
chrifro force-pushed the chrifro/hover-info-tooltips branch from 98979c5 to 3c87700 Compare September 11, 2026 13:44
@chrifro
chrifro force-pushed the chrifro/hover-info-tooltips branch from 3c87700 to cf1cb75 Compare September 11, 2026 14:07
@chrifro
chrifro requested a review from aslilac September 11, 2026 14:20
@aslilac
aslilac added this pull request to stack #29439 September 16, 2026 22:58
@chrifro
chrifro force-pushed the chrifro/hover-info-tooltips branch 2 times, most recently from 661a3ed to 8180765 Compare September 17, 2026 10:22
@chrifro
chrifro force-pushed the chrifro/hover-info-tooltips branch from 8180765 to 246d154 Compare September 17, 2026 10:25
Base automatically changed from chrifro/hover-tooltips-foundation to main September 18, 2026 09:17
chrifro added a commit that referenced this pull request Sep 18, 2026
…28903)

Part 1 of 2 of the tooltip cleanup (split for review). This PR adds the
reusable piece; the follow-up migrates call sites.

Makes `InfoTooltip` a **hover** tooltip built on the shared `Tooltip`
instead of the click-based `HelpPopover`, and consolidates hover timing:

- `type` (`info` / `warning`) and `size` (`small` / `medium`) props
- right / center placement (`side="right"`, `align="center"`)
- `size="sm"` links spaced from the body text
- `TOOLTIP_DELAY_DURATION` (100ms) shared by the app-wide provider and
`InfoTooltip`, so info tooltips no longer inherit Radix's 700ms default

No call sites change here beyond the existing `InfoTooltip` consumers
picking up the new hover behavior automatically.

### Before / After

The affordance reveals on hover (was click), uses the info / warning
icon (was a `?`), opens to the right, and is snappier (100ms vs 700ms).

<img width="320"
src="https://raw.githubusercontent.com/coder/coder/429b230efbe38bfa3f7fc2bac5c8fad71fa50e4a/.assets/after-info.png"
/> <img width="320"
src="https://raw.githubusercontent.com/coder/coder/429b230efbe38bfa3f7fc2bac5c8fad71fa50e4a/.assets/after-warning.png"
/>

### Stack

- **This PR (1/2):** the `InfoTooltip` component + shared delay.
- **Follow-up (2/2):** #28875 — migrate the click `HelpPopover` info
affordances across pages/modules to this component.

---

🤖 Generated with Coder Agents on behalf of @chrifro.
Replace the click-based HelpPopover info affordances across pages and
modules with the hover InfoTooltip (and base Tooltip for status/latency
indicators). Genuinely interactive popovers (update actions, forms,
breadcrumb hovercards) stay click based.

Stacked on the InfoTooltip foundation change.
@chrifro
chrifro force-pushed the chrifro/hover-info-tooltips branch from 246d154 to 61cbf61 Compare September 18, 2026 09:17
@chrifro
chrifro merged commit c2c3ecc into main Sep 18, 2026
27 checks passed
@chrifro
chrifro deleted the chrifro/hover-info-tooltips branch September 18, 2026 09:32
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants