Repository navigation
feat(site/src): hide Browser, Desktop, and Debug panels behind the add-panel dropdown - #28370
Conversation
91d2736 to
8cd3e18
Compare
Documentation CheckUpdates Needed
Automated review via Coder Agents |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91d2736a02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
6c72e68 to
45a2d7f
Compare
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jakehwll
left a comment
There was a problem hiding this comment.
Something needs to be done about how we handle localStorage but not the scope of this PR. LGTM.
6837893 to
a5d1ce4
Compare
Move the Browser, Desktop, and Debug right-panel tabs behind the add-panel dropdown. Each panel starts hidden, appears once, and can be hidden again from the dropdown or from an X control on its tab. Visibility is stored per chat, so a panel returns after a reload. Hiding a panel by default also stops the agent-browser iframe from mounting in chats where the user never opens the Browser panel. Terminal behavior is unchanged and still allows multiple tabs.
Seed the saved Browser choice in the two negative Browser stories. Both stories now prove the health gate and the agent-binding gate hide the tab, instead of passing because panels start hidden. Add a story that shows a singleton panel in an archived chat and asserts that the per-chat entry stays absent. Type the story seed helper with SingletonRightPanelTabId, and drop a duplicate comment in the add-panel dropdown stories.
Compute the visible-and-supported singleton tab list a single time and pass it straight to the add-tab control, and inline the single-use handleOpenDesktop wrapper.
a5d1ce4 to
77a34fd
Compare
The Browser, Desktop, and Debug right-panel tabs appeared automatically whenever the deployment supported them, so every chat with an
agent-browserapp mounted the app iframe at page load even if the user never opened the panel.These panels now start hidden and are toggled from the existing add-panel dropdown as checkbox items. Each visible tab gets an X close control, each panel can appear at most once, and visibility is persisted per chat. Unsupported panels are hidden from both the dropdown and the tab list, but a saved choice survives a temporary loss of support. Summary, Git, and Terminal are unchanged.
Notes:
getEffectiveTabIddrops its unreachabledesktopChatIdfallback,DropdownMenuCheckboxItemis new and reusesmenuItemClass, and existing chats lose these tabs on first load after deploy since there is no migration.Opened by Coder Agents on behalf of @ethanndickson.