Skip to content

feat(site/src): hide Browser, Desktop, and Debug panels behind the add-panel dropdown - #28370

Merged
ethanndickson merged 4 commits into
mainfrom
feat/right-panel-singleton-tabs
Sep 9, 2026
Merged

ethanndickson merged 4 commits into
mainfrom
feat/right-panel-singleton-tabs

Conversation

@ethanndickson

@ethanndickson ethanndickson commented Aug 20, 2026 •

Copy link
Copy Markdown
Member

The Browser, Desktop, and Debug right-panel tabs appeared automatically whenever the deployment supported them, so every chat with an agent-browser app mounted the app iframe at page load even if the user never opened the panel.

These panels now start hidden and are toggled from the existing add-panel dropdown as checkbox items. Each visible tab gets an X close control, each panel can appear at most once, and visibility is persisted per chat. Unsupported panels are hidden from both the dropdown and the tab list, but a saved choice survives a temporary loss of support. Summary, Git, and Terminal are unchanged.

image

Notes: getEffectiveTabId drops its unreachable desktopChatId fallback, DropdownMenuCheckboxItem is new and reuses menuItemClass, and existing chats lose these tabs on first load after deploy since there is no migration.


Opened by Coder Agents on behalf of @ethanndickson.

@ethanndickson
ethanndickson marked this pull request as ready for review August 26, 2026 13:17
@ethanndickson
ethanndickson force-pushed the feat/right-panel-singleton-tabs branch from 91d2736 to 8cd3e18 Compare August 26, 2026 13:17
@coderagents

coderagents Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Documentation Check

Updates Needed

  • docs/ai-coder/agents/platform-controls/chat-debug-logging.md - This PR makes the Browser, Desktop, and Debug right-panel tabs hidden by default; they now appear only after the user enables them from the add-panel dropdown. The doc currently states a Debug tab appears automatically ("When debug logging is active for a chat, a Debug tab appears in the right panel...") and the export steps say "Open the Debug tab in the right panel." Update this to note the user must first add/enable the Debug panel via the add-panel dropdown before the tab is available.

Automated review via Coder Agents

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 91d2736a02

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 6c72e68dd1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ethanndickson
ethanndickson force-pushed the feat/right-panel-singleton-tabs branch from 6c72e68 to 45a2d7f Compare September 3, 2026 18:15
@ethanndickson

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-03T18:20:19.549714Z 45a2d7f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 45a2d7f0ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jakehwll jakehwll left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something needs to be done about how we handle localStorage but not the scope of this PR. LGTM.

@ethanndickson
ethanndickson force-pushed the feat/right-panel-singleton-tabs branch 2 times, most recently from 6837893 to a5d1ce4 Compare September 8, 2026 04:46
Move the Browser, Desktop, and Debug right-panel tabs behind the
add-panel dropdown. Each panel starts hidden, appears once, and can be
hidden again from the dropdown or from an X control on its tab.
Visibility is stored per chat, so a panel returns after a reload.

Hiding a panel by default also stops the agent-browser iframe from
mounting in chats where the user never opens the Browser panel.

Terminal behavior is unchanged and still allows multiple tabs.
Seed the saved Browser choice in the two negative Browser stories. Both
stories now prove the health gate and the agent-binding gate hide the
tab, instead of passing because panels start hidden.

Add a story that shows a singleton panel in an archived chat and asserts
that the per-chat entry stays absent.

Type the story seed helper with SingletonRightPanelTabId, and drop a
duplicate comment in the add-panel dropdown stories.
Compute the visible-and-supported singleton tab list a single time and
pass it straight to the add-tab control, and inline the single-use
handleOpenDesktop wrapper.
@ethanndickson
ethanndickson force-pushed the feat/right-panel-singleton-tabs branch from a5d1ce4 to 77a34fd Compare September 9, 2026 01:58
@ethanndickson
ethanndickson merged commit 518d230 into main Sep 9, 2026
26 checks passed
@ethanndickson
ethanndickson deleted the feat/right-panel-singleton-tabs branch September 9, 2026 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants