Skip to content

fix: bump Go version from 1.26.4 to 1.26.5 - #27157

Merged
mtojek merged 1 commit into
mainfrom
fix/go-1.26.5
Jul 14, 2026
Merged

mtojek merged 1 commit into
mainfrom
fix/go-1.26.5

Conversation

@denisra

@denisra denisra commented Jul 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Bump Go toolchain from 1.26.4 to 1.26.5.

Go 1.26.5 (released 2026-07-07) includes security fixes addressing:

These were flagged by the IronBank scan of coder/coder-enterprise/coder-service-2:2.34.5.

Changes

  • go.mod: go 1.26.4 to go 1.26.5 (language version floor)
  • mise.toml / mise.lock: Go toolchain pin 1.26.4 to 1.26.5 (this is what actually compiles the scanned artifact and clears the CVEs)

Related

Linear: ENT-129

@denisra

denisra commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator Author

/coder-agents-review

@coder-agents-review

coder-agents-review Bot commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

Chat: Review posted | View chat
Requested: 2026-07-13 13:20 UTC by @denisra
Spend: $7.13 / $100.00

Review history
  • R1 (2026-07-13): 9 reviewers, 2 Note, 1 P2, COMMENT. Review

deep-review v0.9.0 | Round 1 | 9af3d31..b6f099d

Last posted: Round 1, 3 findings (1 P2, 2 Note), COMMENT. Review

Finding inventory

Finding inventory: PR #27157

Findings

# Sev Status Location Summary Round Reviewer Posted
CRF-1 P2 Open commit b6f099d Commit body cites Ref: ENT-126 but PR description cites Linear: ENT-129 R1 Leorio Yes
CRF-2 Note Open go.mod:3 PR ## Changes understates the mise.toml/mise.lock toolchain bump (the actual security lever) R1 Pariston, Leorio Yes
CRF-3 Note Open commit b6f099d Commit body CVE/package reading order pairs each CVE with the opposite package vs the correct mapping R1 Leorio Yes

Round log

Round 1

Panel (Netero + Bisky, Gon, Hisoka, Leorio, Mafu-san, Mafuuu, Pariston, Zoro, Kite).
Go toolchain bump 1.26.4 -> 1.26.5 across go.mod, mise.toml, mise.lock.
No code/build/security defects. Six reviewers (Netero, Mafu-san, Mafuuu, Pariston, Zoro, Kite) independently
verified all five mise.lock SHA256 checksums against upstream go.dev; all match. check_go_versions.sh passes;
no stale 1.26.4 references remain. Only findings are documentation-integrity issues in the commit message and
PR description: 1 P2, 2 Note. Reviewed against 9af3d31..b6f099d.

About deep-review

CRF = Coder Review Finding (P0-P4, Nit, Note)

Reviewer Focus
Bisky tests
Chopper ops/errors
Churn-guard change verification
Ging language modernization
Gon naming
Hisoka edge cases
Killua perf
Kite change integrity
Knov contracts
Knuckle SQL
Komugi flake/determinism
Kurapika security
Law decomposition
Leorio docs
Luffy product
Mafu-san process
Mafuuu contracts
Melody dispatch/pairing
Meruem structural
Nami frontend
Netero mechanical checks
Pariston premise testing
Pen-botter product gaps
Razor verification
Robin duplication
Ryosuke Go arch
Takumi concurrency
Zoro shape

🤖 Managed by Coder Agents.

@coder-agents-review coder-agents-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clean, correctly scoped security bump: Go toolchain 1.26.4 -> 1.26.5 across go.mod, mise.toml, and mise.lock, single-concern with no scope creep. The panel could not fault the change itself. Six reviewers independently fetched Go's published checksums and confirmed all five mise.lock SHA256 values match upstream byte-for-byte; check_go_versions.sh passes (go.mod, mise.toml, and flake.nix major.minor all agree); and a tree-wide grep found no stale 1.26.4 references, so no sibling pin was missed. The CVE claims also check out: CVE-2026-39822 is the os.Root symlink traversal and CVE-2026-42505 is the crypto/tls ECH pre-shared-key identity leak, both fixed in 1.26.5. As Hisoka put it: "I came to fight a Go bump and found nothing that fights back."

Severity count: 1 P2, 2 Note. All three are documentation-integrity issues in the permanent record, not code defects, and all are fixable in this PR before merge. The inline comments are anchored on the go directive line since the issues live in the commit message and PR prose, outside the code diff.

🤖 This review was automatically generated with Coder Agents.

Comment thread go.mod Resolved
Comment thread go.mod Resolved
Comment thread go.mod Resolved
@linear-code

linear-code Bot commented Jul 13, 2026

Copy link
Copy Markdown

ENT-129

Go 1.26.5 (released 2026-07-07) includes security fixes addressing:

- CVE-2026-39822: os package
- CVE-2026-42505: crypto/tls package

Flagged by the IronBank scan of coder/coder-enterprise/coder-service-2:2.34.5.

The scanned artifact is compiled by the mise-pinned toolchain, so the
mise.toml/mise.lock pins are what actually clear the CVEs from the
IronBank-scanned binary; the go.mod directive raises the language floor.

Ref: ENT-129
@mtojek
mtojek merged commit 553c9ec into main Jul 14, 2026
35 of 36 checks passed
@mtojek
mtojek deleted the fix/go-1.26.5 branch July 14, 2026 10:49
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants