Repository navigation
fix: bump Go version from 1.26.4 to 1.26.5 - #27157
Conversation
4731d65 to
b6f099d
Compare
|
/coder-agents-review |
|
Chat: Review posted | View chat Review history
deep-review v0.9.0 | Round 1 | Last posted: Round 1, 3 findings (1 P2, 2 Note), COMMENT. Review Finding inventoryFinding inventory: PR #27157Findings
Round logRound 1Panel (Netero + Bisky, Gon, Hisoka, Leorio, Mafu-san, Mafuuu, Pariston, Zoro, Kite). About deep-reviewCRF = Coder Review Finding (P0-P4, Nit, Note)
|
There was a problem hiding this comment.
This is a clean, correctly scoped security bump: Go toolchain 1.26.4 -> 1.26.5 across go.mod, mise.toml, and mise.lock, single-concern with no scope creep. The panel could not fault the change itself. Six reviewers independently fetched Go's published checksums and confirmed all five mise.lock SHA256 values match upstream byte-for-byte; check_go_versions.sh passes (go.mod, mise.toml, and flake.nix major.minor all agree); and a tree-wide grep found no stale 1.26.4 references, so no sibling pin was missed. The CVE claims also check out: CVE-2026-39822 is the os.Root symlink traversal and CVE-2026-42505 is the crypto/tls ECH pre-shared-key identity leak, both fixed in 1.26.5. As Hisoka put it: "I came to fight a Go bump and found nothing that fights back."
Severity count: 1 P2, 2 Note. All three are documentation-integrity issues in the permanent record, not code defects, and all are fixable in this PR before merge. The inline comments are anchored on the go directive line since the issues live in the commit message and PR prose, outside the code diff.
🤖 This review was automatically generated with Coder Agents.
Go 1.26.5 (released 2026-07-07) includes security fixes addressing: - CVE-2026-39822: os package - CVE-2026-42505: crypto/tls package Flagged by the IronBank scan of coder/coder-enterprise/coder-service-2:2.34.5. The scanned artifact is compiled by the mise-pinned toolchain, so the mise.toml/mise.lock pins are what actually clear the CVEs from the IronBank-scanned binary; the go.mod directive raises the language floor. Ref: ENT-129
Summary
Bump Go toolchain from 1.26.4 to 1.26.5.
Go 1.26.5 (released 2026-07-07) includes security fixes addressing:
ospackagecrypto/tlspackageThese were flagged by the IronBank scan of
coder/coder-enterprise/coder-service-2:2.34.5.Changes
go.mod:go 1.26.4togo 1.26.5(language version floor)mise.toml/mise.lock: Go toolchain pin 1.26.4 to 1.26.5 (this is what actually compiles the scanned artifact and clears the CVEs)Related
release/2.35release/2.34Linear: ENT-129