Skip to content

refactor(coderd/x/chatd): clarify task side effects - #26515

Closed
hugodutka wants to merge 2 commits into
mainfrom
fix-chatd-tasks-review
Closed

hugodutka wants to merge 2 commits into
mainfrom
fix-chatd-tasks-review

Conversation

@hugodutka

Copy link
Copy Markdown
Collaborator

Addresses deferred PR #26109 review comments around taskStarter side-effect seams and requires-action timeout cancellation.

Extracts task side effects behind an interface, makes newTaskStarter required dependencies explicit, adds GoMock coverage for the task side-effect seam, and moves the requires-action deadline check into the chatstate transition.

Comments addressed:

Coder Agents generated this PR.

@github-actions github-actions Bot added the stale This issue is like stale bread. label Jun 28, 2026
@github-actions github-actions Bot closed this Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale This issue is like stale bread.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant