Skip to content

chore: remove Nix dev image from dogfood template and pipeline - #26022

Merged
matifali merged 1 commit into
mainfrom
matifali/remove-dogfood-nix
Jun 3, 2026
Merged

matifali merged 1 commit into
mainfrom
matifali/remove-dogfood-nix

Conversation

@matifali

@matifali matifali commented Jun 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The Nix dogfood image (codercom/oss-dogfood-nix) is unused. The current mise
setup covers the same tooling with far less complexity, so this removes the dev
image and its build/publish pipeline.

Per Thomas's review, the package outputs and devShells.default stay for NixOS
users in the company; only the dev-image bits are removed.

Changes

Area Change
dogfood/coder/main.tf Drop the Dogfood Nix (Experimental) image option and its image_tags entry
.github/workflows/dogfood.yaml Drop the nix matrix entry, the Setup Nix / cache-nix-action steps, the Build/Push Nix image steps, and the flake.lock/flake.nix path triggers. Simplify the now-redundant != 'nix' step guards
flake.nix Remove the dev_image output and the docker (nix/docker.nix) helper
nix/docker.nix Deleted

Note

pnpm2nix is kept intentionally. It feeds buildSite → the packages.*
(coder binary) outputs, not the dev image, so removing it would break
nix build for NixOS users.

Validation

  • terraform fmt -check + terraform validate pass for dogfood/coder
  • actionlint passes on the workflow
  • make pre-commit-light passes (fmt, emdash, typos, shellcheck, actionlint)
  • nix is intentionally absent from the dogfood image, so the flake change was
    reviewed by hand; pnpm2nix, devShells.default, and packages.* are retained
Decision log
  • Originally scoped to also drop the pnpm2nix input, but it's required by the
    package build we're keeping, so it stays.
  • Removing nix from the matrix makes the matrix.image-version != 'nix' guards
    always-true; simplified them so the workflow doesn't reference a matrix value
    that no longer exists (!= 'nix' && !fork → ${{ !fork }}).
  • Fork PRs no longer build the Nix image as side-effect validation. The base+mise
    pipeline already can't run on forks (read-only GITHUB_TOKEN), so nothing is lost.

🤖 This PR was created with the help of Coder Agents, and needs a human review. 🧑‍💻

The Nix-based dogfood image (codercom/oss-dogfood-nix) is unused. The
current mise setup covers the same tooling with far less complexity, so
remove the dev image and its build/publish pipeline.

- dogfood/coder/main.tf: drop the "Dogfood Nix (Experimental)" image
  option and its image_tags entry.
- .github/workflows/dogfood.yaml: drop the nix matrix entry, the Setup
  Nix/cache and Build/Push Nix image steps, the flake path triggers, and
  simplify the now-redundant "!= 'nix'" step guards.
- flake.nix: remove the dev_image output and the docker (nix/docker.nix)
  helper. Keep pnpm2nix, devShells.default, and the package outputs for
  NixOS users.
- Delete nix/docker.nix.
@matifali matifali self-assigned this Jun 3, 2026
@ThomasK33

Copy link
Copy Markdown
Member

@codex review
@claude review
/coder-agents-review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b979c0faed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread dogfood/coder/main.tf Resolved
@matifali
matifali merged commit 6ef687c into main Jun 3, 2026
60 checks passed
@matifali
matifali deleted the matifali/remove-dogfood-nix branch June 3, 2026 11:49
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants