Repository navigation
Conversation
WebRTC uses UDP, which means a network connection is never open or closed. It uses timeouts to determine connection state; on a slow CI runner, these timeouts could be reached. Increasing this timeout should reduce flakes, but is unlikely to remove this flake entirely.
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 71.31% 71.47% +0.15%
==========================================
Files 37 37
Lines 1311 1311
Branches 7 7
==========================================
+ Hits 935 937 +2
+ Misses 302 300 -2
Partials 74 74
Continue to review full report at Codecov.
|
| ) | ||
|
|
||
| const ( | ||
| disconnectedTimeout = time.Millisecond * 200 |
There was a problem hiding this comment.
thought (non-blocking): It's not clear to me why it would timeout at all given the connections are local 🤔
There was a problem hiding this comment.
When CPU is contended in CI... this flake occurred because it took >200ms to negotiate the connection (which is ridiculously slow execution)!
bryphe-coder
left a comment
There was a problem hiding this comment.
Glad this improves the reliability of the tests! Increasing timeouts alone always makes me nervous (because code always finds a way of running just slow enough to still hit the timeout...) but cleaning up the servers with sch.Close() seems like it will help, too
Thanks for investigating these flaky test runs!
|
Also looks like one we could backport to |
|
Pushed 80b93e0 addressing the actionable findings from the deep review with the smallest reasonable diff. Resolved
Deferred (out of scope for the smallest safe diff)
Validation:
This follow-up was generated by Coder Agents. |
> 🤖 This PR was modified by Coder Agents on behalf of Jake Howell. Replaces the three screenshots under `docs/images/admin/licenses/` with Figma-exported previews in the same 896px style as #29455, reflecting the current Licenses UI. The old `licenses-screen.png` predated the Products / Add-ons license card (Coder Workspaces, Coder Agents, AI Governance). Image-only change; no docs text or paths were modified. Referenced from `docs/admin/licensing/index.md` and `docs/tutorials/faqs.md`. Files are 40-60% smaller and no longer carry EXIF metadata. | Old | New | |---|---| | <img width="448" alt="licenses-screen (old)" src="https://raw.githubusercontent.com/coder/coder/53ad29512def2e562f41fc17509508896980605e/docs/images/admin/licenses/licenses-screen.png" /> | <img width="448" alt="licenses-screen (new)" src="https://raw.githubusercontent.com/coder/coder/1a18a0ee925d12cecfb1e2cee5e37b22602a3629/docs/images/admin/licenses/licenses-screen.png" /> | | <img width="448" alt="licenses-nolicense (old)" src="https://raw.githubusercontent.com/coder/coder/53ad29512def2e562f41fc17509508896980605e/docs/images/admin/licenses/licenses-nolicense.png" /> | <img width="448" alt="licenses-nolicense (new)" src="https://raw.githubusercontent.com/coder/coder/1a18a0ee925d12cecfb1e2cee5e37b22602a3629/docs/images/admin/licenses/licenses-nolicense.png" /> | | <img width="448" alt="add-license-ui (old)" src="https://raw.githubusercontent.com/coder/coder/53ad29512def2e562f41fc17509508896980605e/docs/images/admin/licenses/add-license-ui.png" /> | <img width="448" alt="add-license-ui (new)" src="https://raw.githubusercontent.com/coder/coder/1a18a0ee925d12cecfb1e2cee5e37b22602a3629/docs/images/admin/licenses/add-license-ui.png" /> | <details> <summary>Verification</summary> - Every visible label in the new images maps to a current string in `site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/` (`LicenseCard.tsx`, `LicensesSettingsPageView.tsx`, `AddNewLicensePageView.tsx`, `CoderWorkspacesProductCard.tsx`, `CoderAgentsProductCard.tsx`). - Mock license data only: license #26, 64/100 seats, valid August 27, 2024 to August 27, 2027. No license key, deployment ID, or email visible. - Dimensions 896x512 / 896x352 / 896x512, matching the `docs/images/screenshots/` convention from #29455. </details>
WebRTC uses UDP, which means a network connection is never open or closed. It uses timeouts to determine connection state; on a slow CI runner, these timeouts could be reached. Increasing this timeout should reduce flakes, but is unlikely to remove this flake entirely.