Skip to content

fix: Use WebSockets to stream workspace build logs - #2569

Merged
kylecarbs merged 6 commits into
mainfrom
wslogs
Jun 22, 2022
Merged

kylecarbs merged 6 commits into
mainfrom
wslogs

Conversation

@kylecarbs

@kylecarbs kylecarbs commented Jun 22, 2022 •

Copy link
Copy Markdown
Member

This was using a streaming HTTP request before, which didn't work
on my version of Chrome. This method seemed less reliable and standard
than a WebSocket, so figured switching would be best.

Fixes #2570

This was using a streaming HTTP request before, which didn't work
on my version of Chrome. This method seemed less reliable and standard
than a WebSocket, so figured switching would be best.
@kylecarbs
kylecarbs requested a review from AbhineetJain June 22, 2022 03:31
@kylecarbs
kylecarbs requested a review from a team as a code owner June 22, 2022 03:31
@kylecarbs kylecarbs self-assigned this Jun 22, 2022

@AbhineetJain AbhineetJain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! Some minor comments.

Comment thread site/src/api/api.ts Resolved
kylecarbs and others added 3 commits June 22, 2022 08:02
Co-authored-by: Abhineet Jain <AbhineetJain@users.noreply.github.com>
Co-authored-by: Abhineet Jain <AbhineetJain@users.noreply.github.com>
Co-authored-by: Abhineet Jain <AbhineetJain@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

templates with parameter cannot be updated

3 participants