Repository navigation
fix: extract key when BYOK header is given with delegated auth - #25688
Merged
Merged
Conversation
Signed-off-by: Danny Kopping <danny@coder.com>
Adjust delegated auth path to only require a header key when not delegated, and lock in via tests that SessionKey is propagated when a key is present (BYOK) and empty when it isn't (delegated centralized). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ibetitsmike
approved these changes
May 26, 2026
johnstcn
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were only extracting the API when not delegating auth; this is incorrect.
We need to extract the key always when BYOK is intended.