Repository navigation
fix(dogfood/coder): override mise oci build MISE_CONFIG_DIR bake - #25684
Merged
Merged
Conversation
mise oci build bakes ENV MISE_CONFIG_DIR=/etc/mise into the synthesized image layer, which silently breaks loading of ~/.config/mise/conf.d/*, including the user-owned trust file install-deps seeds. Change-Id: I3857a1a2a12a19faee3dca4f9c11100d099183cd Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Kosiewski <tk@coder.com>
ThomasK33
marked this pull request as ready for review
May 26, 2026 16:25
ibetitsmike
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside the dogfood workspace,
mise config lsdoesn't load~/.config/mise/config.tomlor~/.config/mise/conf.d/*becausemise oci buildbakesENV MISE_CONFIG_DIR=/etc/miseinto the synthesized image layer that sits on top of Dockerfile.base. That silently drops the user-owned trust file theinstall-depscoder_script seeds at workspace start (dogfood/coder/main.tf:705-727), so the user-editable mise trust path config never takes effect.The natural place for this would be
[oci.env]in the projectmise.toml, but a probe build confirms mise's internal env bake currently wins onMISE_*key collisions (non-MISE keys flow through). SettingMISE_CONFIG_DIRincoder_agent.envworks around that by applying after the image ENV resolves. The comment in the diff calls out moving this back to[oci.env]once upstream mise respects user values.🤖 Generated with Claude Code