Skip to content

fix(site/src): account for iOS visual viewport offset - #25619

Merged
jaaydenh merged 5 commits into
mainfrom
fix/mobile-personal-skills-popup-ios-viewport
May 22, 2026
Merged

jaaydenh merged 5 commits into
mainfrom
fix/mobile-personal-skills-popup-ios-viewport

Conversation

@jaaydenh

Copy link
Copy Markdown
Collaborator

Summary

  • Compute mobile dropdown bottom offsets in layout-viewport coordinates, matching the fixed Radix popover wrapper.
  • Use visualViewport.offsetTop to clamp the above-composer popup height when iOS WebKit pans the visual viewport for the soft keyboard.
  • Align mobile dropdown width/left to the chat composer and add a Storybook regression for shifted visual viewports.

Testing

  • cd site && pnpm tsc --noEmit -p .
  • cd site && pnpm test:storybook src/pages/AgentsPage/components/ChatMessageInput/ChatMessageInput.stories.tsx
  • cd site && pnpm lint

Manual mobile verification

Start dev mode with ./scripts/develop.sh, open the forwarded port 8080 URL on a real iPhone in Safari and Chrome, focus the Agents chat input, type /, and verify the personal skills popup appears directly above the composer, stays within the visible viewport while the keyboard is open, and scrolls internally for long lists.

Generated by Coder Agents.

@jaaydenh
jaaydenh requested a review from ibetitsmike May 22, 2026 15:18
@jaaydenh
jaaydenh merged commit ef3f95a into main May 22, 2026
42 of 43 checks passed
@jaaydenh
jaaydenh deleted the fix/mobile-personal-skills-popup-ios-viewport branch May 22, 2026 15:36
@github-actions github-actions Bot locked and limited conversation to collaborators May 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants