Repository navigation
Conversation
Adds three new UserAppearanceSettings fields (theme_mode, theme_light, theme_dark) on top of the existing theme_preference and terminal_font. Replaces GetUserThemePreference and GetUserTerminalFont with a single GetUserAppearanceSettings aggregate query. The PUT handler is wrapped in db.InTx so sync-mode's mode + slot writes can never half-apply.
jaaydenh
force-pushed
the
feat/theme-mode-dropdown-ui
branch
from
May 8, 2026 12:50
ee412f4 to
ec11246
Compare
aslilac
reviewed
May 8, 2026
aslilac
left a comment
Member
There was a problem hiding this comment.
both of these PRs are pretty chonky, but over 2kloc added is way too much for one PR
| document.querySelector("html")?.setAttribute("class", htmlClassName); | ||
|
|
||
| return ( | ||
| <StrictMode> |
Member
There was a problem hiding this comment.
why do agents keep trying to make this change for no reason? knock it off 😭
Collaborator
Author
There was a problem hiding this comment.
they will keep doing it because they are seeing this error, 'React' refers to a UMD global, but the current file is a module. Consider adding an import instead.ts(2686)
Collaborator
Author
|
@aslilac I can look into breaking it up again, its already been 3 PRs so far maybe 4 will be enough. |
Collaborator
Author
|
This has been split into smaller PRs for review:
I am leaving this original PR open for now so the author can decide whether to close it or keep it as the tracking PR. |
jaaydenh
added a commit
that referenced
this pull request
May 14, 2026
…gs (#25076) Part 1: Backend portion of a change broken into 2 PRs. Part 2: #25077 Adds three new UserAppearanceSettings fields (theme_mode, theme_light, theme_dark) on top of the existing theme_preference and terminal_font. Replaces GetUserThemePreference and GetUserTerminalFont with a single GetUserAppearanceSettings aggregate query. The PUT handler is wrapped in db.InTx so sync-mode's mode + slot writes can never half-apply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 2 part change. Part 1 #25076
Replaces the flat theme grid on the Appearance settings page with a
Theme mode dropdown that exposes 'Sync with system' and 'Single theme'
modes. Adds themeMode helpers, a usePreferredColorScheme hook, swatch
and preview components, plus optimistic-cache rollback in the
appearance mutation.
Includes incidental tritan palette refinements, AgentsPage diff CSS
touch-up, Storybook strict-mode import shuffle, and .gitattributes
whitespace rules carried over from the original branch's rebase.
Builds on the schema landed in #25076.
Produced with Coder Agents assistance.