chore: update design of add users dialog#24287
Merged
Merged
Conversation
github-actions
Bot
added
the
community
jaaydenh
removed
the
community
jaaydenh
commented
Apr 13, 2026
Comment on lines
-139
to
-149
| <div className="max-h-[360px] overflow-auto"> | ||
| <Table> | ||
| <TableBody className="[&_td]:h-[72px]"> | ||
| <div className="h-96 w-full rounded-lg border border-border border-solid"> | ||
| <div className="h-full overflow-hidden p-px"> | ||
| <div | ||
| className="h-full overflow-y-auto overflow-x-hidden overscroll-contain" | ||
| onWheel={(event) => { | ||
| event.stopPropagation(); | ||
| }} | ||
| > | ||
| <UsersTable | ||
| error={error} | ||
| onChange={onChange} | ||
| selected={selected} | ||
| users={users} | ||
| /> | ||
| </TableBody> | ||
| </Table> |
Contributor
Author
There was a problem hiding this comment.
The new design called for scrolling inside a container instead of having the entire table scroll. I couldn't find a good way to make that work using the various Table components so opted out of them for this implementation.
Member
aslilac
approved these changes
Apr 13, 2026
Member
|
code looks fine, but it'd probably be good to check with jake to make sure we're not stepping on each others toes, as asher mentioned |
jakehwll
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update design to match Figma design
Figma: https://www.figma.com/design/klGTlHSPQwI4KBvAMdebrx/Customer-Usage-Controls-for-AI-Governance-Add-On?node-id=448-9898&m=dev
Before:
After: