feat(site): wrap behavior page sections in CollapsibleSection cards#23991
Closed
DanielleMaywood wants to merge 1 commit into
Closed
feat(site): wrap behavior page sections in CollapsibleSection cards#23991DanielleMaywood wants to merge 1 commit into
DanielleMaywood wants to merge 1 commit into
Conversation
This was referenced Apr 2, 2026
d1126ba to
5a71b01
Compare
9091556 to
b4985b7
Compare
2df2da3 to
8c37a80
Compare
4f8626a to
d26f486
Compare
8c37a80 to
4a8ae12
Compare
d26f486 to
2e423be
Compare
4a8ae12 to
1339fdf
Compare
2e423be to
bcc3f46
Compare
1339fdf to
c9b492e
Compare
bcc3f46 to
b6bee09
Compare
d763bdd to
fcfb877
Compare
b6bee09 to
8f3b539
Compare
fcfb877 to
254e305
Compare
8f3b539 to
c9ce05b
Compare
f79e590 to
be3c23d
Compare
a28536d to
fcfa599
Compare
be3c23d to
646b432
Compare
fcfa599 to
de846d8
Compare
646b432 to
669328e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 2/4 in a stack to unify agent settings pages.
What
Wraps all Behavior page sections in
CollapsibleSectioncards and cleans up the compaction settings component.Why
The settings pages currently use flat
<hr>dividers between sections, which makes it hard to visually group related controls. Wrapping each section in a collapsible bordered card gives clearer visual boundaries and lets users collapse sections they are not actively editing. This is the same pattern the Spend page (PR 4) uses, so applying it to Behavior first establishes consistency across the settings area.Changes
AgentSettingsBehaviorPageView— each section (Instructions, Context Compaction, System Instructions, Virtual Desktop, Workspace Autostop, Kyleosophy) wrapped in<CollapsibleSection>. Admin sections showAdminBadgein the badge slot and toggle switches in the action slot. TheAdminBadgecomponent has a built-inml-autoclass that would push it to the right inside the CollapsibleSection header — the badge slot wraps it with[&>*]:ml-0to neutralize this.UserCompactionThresholdSettings— gains ahideHeaderprop so the CollapsibleSection card can provide the header instead. The header block (title + description) was previously duplicated 3 times across loading/error/success branches; now hoisted to a singleconst headerBlockat the top of the component. Cancel/Save buttons moved out ofTableFooterinto a standalone<div className="flex justify-end gap-2 pt-2">— Save is always visible (disabled whendirtyRows.length === 0) so users can see the action exists without needing to make edits first.Stories — updated 3 play functions that referenced the renamed section title ("Personal Instructions" → "Instructions"), and 3
UserCompactionThresholdSettingsassertions that expected the Save button to be absent when no rows are dirty (it is now always rendered but disabled).Stack