fix(site): make settings header scrollable so Safari PWA can reach back button#23742
Draft
DanielleMaywood wants to merge 1 commit intomainfrom
Draft
fix(site): make settings header scrollable so Safari PWA can reach back button#23742DanielleMaywood wants to merge 1 commit intomainfrom
DanielleMaywood wants to merge 1 commit intomainfrom
Conversation
github-actions
bot
added
the
community
…ck button In Safari standalone (PWA) mode, the virtual keyboard pushes the visual viewport upward without resizing it. When the keyboard dismisses, Safari often fails to restore the scroll position. On the agent settings behavior page, the AgentPageHeader (with the back button) was a sibling above the scroll container, making it unreachable once the viewport shifted. Move the scroll container up to AgentSettingsPage so both the header and settings content scroll as a single unit — the header is always reachable by scrolling up.
DanielleMaywood
force-pushed
the
fix/safari-pwa-keyboard-scroll
branch
from
2e1a900 to
90a73fe
Compare
DanielleMaywood
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Safari standalone (PWA) mode, the virtual keyboard pushes the visual viewport upward without resizing it. When the keyboard dismisses, Safari often fails to restore the scroll position. On the agent settings behavior page, the
AgentPageHeader(with the back button) was a sibling above the scroll container (AgentSettingsPageView), making it permanently unreachable once the viewport shifted.Moves the scroll container from
AgentSettingsPageViewup toAgentSettingsPageso both the header and settings content scroll as a single unit. The back button is always reachable by scrolling up.Decision log
focusout+setTimeout+window.scrollTo(0, 0)workaround inuseAgentsPWAbut rejected it as fragile (magic timeout, browser-behavior dependent).