fix: remove archive/title actions from detail view dropdown#23740
Draft
DanielleMaywood wants to merge 1 commit intomainfrom
Draft
fix: remove archive/title actions from detail view dropdown#23740DanielleMaywood wants to merge 1 commit intomainfrom
DanielleMaywood wants to merge 1 commit intomainfrom
Conversation
github-actions
bot
added
the
community
DanielleMaywood
force-pushed
the
dm/cleanup-detail-dropdown
branch
from
9ec283d to
854630a
Compare
These actions (regenerate title, archive, archive & delete workspace, unarchive) are already available in the sidebar dropdown. Having them duplicated in the detail TopBar dropdown is redundant.
DanielleMaywood
force-pushed
the
dm/cleanup-detail-dropdown
branch
from
854630a to
909711e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the regenerate title, archive, archive & delete workspace, and unarchive menu items from the detail view (TopBar) dropdown. These actions are already available in the sidebar dropdown, so having them in both places was redundant.
The detail view dropdown now only contains workspace-related actions:
Changes
TopBar.tsx: Removed archive/title menu items and their associated props (onArchiveAgent,onUnarchiveAgent,onArchiveAndDeleteWorkspace,onRegenerateTitle,isRegenerateTitleDisabled,hasWorkspace,isArchived) and unused icon importsAgentDetailView.tsx: Removed the now-unnecessary props from all three call sitesTopBar.stories.tsx: RemovedArchived,GenerateTitle, andArchivedWithUnarchivestories and cleaned updefaultProps