Skip to content

fix: scope title regeneration per chat#23729

Merged
ibetitsmike merged 2 commits intomainfrom
mike/agents-title-regeneration
Mar 28, 2026
Merged

fix: scope title regeneration per chat#23729
ibetitsmike merged 2 commits intomainfrom
mike/agents-title-regeneration

Conversation

@ibetitsmike
Copy link
Copy Markdown
Collaborator

Previously, generating a new agent title used a page-global pending state, so one in-flight regeneration disabled the action for every chat in the Agents UI.

This change tracks regenerations by chat ID, updates the Agents page contracts to use regeneratingTitleChatIds, and adds sidebar story coverage that proves only the active chat is disabled.

@ibetitsmike ibetitsmike marked this pull request as ready for review March 28, 2026 00:52
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f056008cf8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibetitsmike
Copy link
Copy Markdown
Collaborator Author

@codex review

1 similar comment
@ibetitsmike
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibetitsmike ibetitsmike changed the title fix(site/src/pages/AgentsPage): scope title regeneration per chat fix: scope title regeneration per chat Mar 28, 2026
@ibetitsmike ibetitsmike force-pushed the mike/agents-title-regeneration branch from 8dafe98 to 0277f7a Compare March 28, 2026 22:18
@ibetitsmike ibetitsmike merged commit bfeb91d into main Mar 28, 2026
29 checks passed
@ibetitsmike ibetitsmike deleted the mike/agents-title-regeneration branch March 28, 2026 23:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants